Bug 115759 – Move CanvasGradient and CanvasPattern in the union of CanvasStyle

• Component: Canvas
• Status: RESOLVED FIXED

[Benjamin Poulain]

Move CanvasGradient and CanvasPattern in the union of CanvasStyle

[Benjamin Poulain]

Created attachment 200975 [details]
Patch

[Benjamin Poulain]

Comment on attachment 200975 [details]
Patch

Clearing flags on attachment: 200975

Committed r149696: <http://trac.webkit.org/changeset/149696>

[Benjamin Poulain]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 200975 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=200975&action=review

> Source/WebCore/html/canvas/CanvasStyle.cpp:130
> -    , m_gradient(gradient)
> +    , m_gradient(gradient.leakRef())
>  {
> +    m_gradient->ref();

This looks like a storage leak to me. We already have a ref because of the call to leakRef, no need to call ref again.

> Source/WebCore/html/canvas/CanvasStyle.cpp:137
> -    , m_pattern(pattern)
> +    , m_pattern(pattern.leakRef())
>  {
> +    m_pattern->ref();

Ditto. Am I right?

[Benjamin Poulain]

Damn! That is right.

Follow up: http://trac.webkit.org/changeset/149706