Summary: | Devirtualize Document class type checking | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||
Component: | DOM | Assignee: | Ryosuke Niwa <rniwa> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | benjamin, commit-queue, d-r, eric.carlson, esprehn+autocc, fmalita, glenn, japhet, jer.noble, kling, koivisto, pdr, schenney | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Ryosuke Niwa
2013-05-07 13:50:48 PDT
Created attachment 200991 [details]
Cleanup
Comment on attachment 200991 [details] Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=200991&action=review > Source/WebCore/dom/Document.h:1486 > + unsigned m_documentClasses; I would just use a uchar8_t here. That way it fits on a word with the 3 boolean bellow. > Source/WebCore/html/HTMLDocument.h:78 > + HTMLDocument(Frame*, const KURL&, unsigned documentClasses = HTMLDocumentClass); I think it should have a default of 0. Otherwise, an caller may think passing something else override the HTMLDocumentClass. Which is not true because the constructor does the right thing. Committed r149705: <http://trac.webkit.org/changeset/149705> |