Add layout test that lists all global constructors

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Chris Dumez]

We should have a layout test that lists all Constructor properties on the window object to better highlight changes to those.

[Chris Dumez]

Created attachment 200901 [details]
WIP Patch

Using ews to get mac results.

[Build Bot]

Comment on attachment 200901 [details]
WIP Patch

Attachment 200901 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/338068

New failing tests:
fast/dom/global-constructors-listing.html

[Build Bot]

Created attachment 200904 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.2

[Chris Dumez]

Created attachment 200905 [details]
Patch

[Kentaro Hara]

Comment on attachment 200905 [details]
Patch

Adding these tests looks reasonable. Would you remove (a part of) LayoutTests/fast/dom/constructed-objects-prototypes.html ? We don't want to manage two tests for this.

[Chris Dumez]

Created attachment 200912 [details]
WIP Patch

[Ryosuke Niwa]

I thought we already had a test for this.

[Chris Dumez]

(In reply to comment #7)
> I thought we already had a test for this.

It was removed when the global constructors were made not enumerable (as it broke the test). However, we can use Object.getOwnPropertyNames(window) to work around this.

[Build Bot]

Comment on attachment 200912 [details]
WIP Patch

Attachment 200912 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/335148

New failing tests:
fast/js/global-constructors-attributes.html

[Build Bot]

Created attachment 200930 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.2

[Chris Dumez]

Created attachment 200933 [details]
Patch

Improve existing test case instead of introducing a new one.

[Benjamin Poulain]

Comment on attachment 200933 [details]
Patch

The test is a great idea. But the results have zero readability.
If one line fail, you would have no idea which constructor is failing the test. The output needs to serialize the value of constructorName.

[Chris Dumez]

Created attachment 201032 [details]
WIP Patch

Using ews to get mac results.

[Chris Dumez]

Created attachment 201056 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 201056 [details]
Patch

Looks good.

[WebKit Commit Bot]

Comment on attachment 201056 [details]
Patch

Clearing flags on attachment: 201056

Committed r149758: <http://trac.webkit.org/changeset/149758>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Roger Fong]

Test fails on mac-lion:
http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r149820%20(12294)/fast/js/global-constructors-attributes-pretty-diff.html

Is this to be expected?

[Chris Dumez]

(In reply to comment #18)
> Test fails on mac-lion:
> http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r149820%20(12294)/fast/js/global-constructors-attributes-pretty-diff.html
> 
> Is this to be expected?

If you don't have NOTIFICATIONS|LEGACY_NOTIFICATIONS enabled, yes. You likely need a platform-specific baseline.

[Chris Dumez]

(In reply to comment #19)
> (In reply to comment #18)
> > Test fails on mac-lion:
> > http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r149820%20(12294)/fast/js/global-constructors-attributes-pretty-diff.html
> > 
> > Is this to be expected?
> 
> If you don't have NOTIFICATIONS|LEGACY_NOTIFICATIONS enabled, yes. You likely need a platform-specific baseline.

FYI, the global baseline is the one from mac-ews. However, it seems the mac port may be enabled NOTIFICATIONS depending on the Mac OS version:
Source/WebCore/Configurations/FeatureDefines.xcconfig:ENABLE_NOTIFICATIONS_macosx_1070 = ;
Source/WebCore/Configurations/FeatureDefines.xcconfig:ENABLE_NOTIFICATIONS_macosx_1080 = ENABLE_NOTIFICATIONS;
Source/WebCore/Configurations/FeatureDefines.xcconfig:ENABLE_NOTIFICATIONS_macosx_1090 = ENABLE_NOTIFICATIONS;

[Roger Fong]

okay, i'll go ahead and rebaseline then, thanks!

[Benjamin Poulain]

Late to the party but LGTM too :)
The results look good now.