Bug 11571

Summary:

Gdk build is out of sync

Product:

WebKit

Reporter:

Alp Toker <alp>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

mrowe

Priority:

Version:

420+

Hardware:

OS:

Linux

Attachments:

Description	Flags
Typo fixes and source file updates to the gdk bakefile	mjs: review+
Only include SVGDocumentExtensions.h when SVG_SUPPORT is defined	mjs: review+
Patch	none
Patch	mitz: review+

Alp Toker

Reported 2006-11-11 05:03:04 PST

The gdk port of WebKit appears to have gone out of sync with the rest of the platform. Attached are an update the existing bakefile rules and other related fixes. Note that these fixes do not yet make it possible to run the launcher test app, but they provide a basis that can continue to be worked upon incrementally. This should not be considered an alternative to merging the cmake build system, but rather a stop-gap solution that will allow work on the gdk port to continue in the meantime.

Attachments
Typo fixes and source file updates to the gdk bakefile (4.67 KB, patch) 2006-11-11 05:06 PST, Alp Toker	mjs: review+	Details Formatted Diff Diff
Only include SVGDocumentExtensions.h when SVG_SUPPORT is defined (421 bytes, patch) 2006-11-11 05:09 PST, Alp Toker	mjs: review+	Details Formatted Diff Diff
Patch (88.01 KB, patch) 2006-11-12 00:00 PST, Mark Rowe (bdash)	no flags	Details Formatted Diff Diff
Patch (88.49 KB, patch) 2006-11-12 00:47 PST, Mark Rowe (bdash)	mitz: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Alp Toker

Comment 1 2006-11-11 05:06:11 PST

Created attachment 11483 [details] Typo fixes and source file updates to the gdk bakefile

Alp Toker

Comment 2 2006-11-11 05:09:49 PST

Created attachment 11484 [details] Only include SVGDocumentExtensions.h when SVG_SUPPORT is defined

Maciej Stachowiak

Comment 3 2006-11-11 09:35:58 PST

Comment on attachment 11484 [details] Only include SVGDocumentExtensions.h when SVG_SUPPORT is defined r=me

Maciej Stachowiak

Comment 4 2006-11-11 09:36:01 PST

Comment on attachment 11483 [details] Typo fixes and source file updates to the gdk bakefile r=me

Mark Rowe (bdash)

Comment 5 2006-11-12 00:00:42 PST

Created attachment 11489 [details] Patch This patch includes the contents of attachment 11483 [details] and attachment 11484 [details], but goes further to allow JSCore and WebCore to compile and link sucessfully. GdkLauncher does not link against WebCore due to two dozen undefined symbols that are related to the loader and screen refactorings from this week.

Mark Rowe (bdash)

Comment 6 2006-11-12 00:47:50 PST

Created attachment 11491 [details] Patch Remove some commented out lines of code.

mitz

Comment 7 2006-11-12 00:48:59 PST

Comment on attachment 11491 [details] Patch r=me

Mark Rowe (bdash)

Comment 8 2006-11-12 00:57:29 PST

Landed in r17741. WebCore should now compile + link correctly, though it will fail with unresolved symbols when being linked into GdkLauncher. Patches for that should be attached to a new bug report.

Note You need to log in before you can comment on or make changes to this bug.