Bug 115679 – [BlackBerry] Web pages can override the visibility of fullscreen video

• Component: WebKit BlackBerry
• Status: RESOLVED INVALID

[Max Feil]

This is a regression caused by the master_41 rebase. My fix for https://przilla.ott.qnx.com/bugzilla/show_bug.cgi?id=290707 was removed for some reason. I am putting the visibility part of that fix back in. The z-index part of that fix is no longer needed in themeBlackBerry.css because it was fixed upstream in fullscreen.css.

Without this fix, fullscreen video (which we enter automatically) can be left with a totally black screen, without spinning green activity indicator or media controls. The user will think that webkit has hung. This affects YouTube, especially over slow network connections. It was also reported recently here: https://przilla.ott.qnx.com/bugzilla/show_bug.cgi?id=246688#c9.

There is another local fix that is being upstreamed with this one, because it was not upstreamed earlier. So in effect this Bug brings themeBlackBerry.css up to date with local changes.

[Max Feil]

Created attachment 200859 [details]
Patch

[Rob Buis]

Comment on attachment 200859 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=200859&action=review

> Source/WebCore/ChangeLog:23
> +        is necessary.

Please do, one for our port only seems best.

> Source/WebCore/css/themeBlackBerry.css:116
> +}

Is this really related?

[Max Feil]

Comment on attachment 200859 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=200859&action=review

>> Source/WebCore/ChangeLog:23
>> +        is necessary.
> 
> Please do, one for our port only seems best.

Ok

>> Source/WebCore/css/themeBlackBerry.css:116
>> +}
> 
> Is this really related?

No, but this is a local change that was not upstreamed yet by whoever made it. I will take it out.

[Rob Buis]

Comment on attachment 200859 [details]
Patch

Clearing review flag since there should be a follow up patch.