Bug 115646

Summary:

HashTraits<RefPtr<P> >::PeekType should be raw pointer for better performance

Product:

WebKit

Reporter:

Mikhail Pozdnyakov <mikhail.pozdnyakov>

Component:

Web Template Framework

Assignee:

Mikhail Pozdnyakov <mikhail.pozdnyakov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, benjamin, buildbot, commit-queue, darin, rniwa, webkit-ews

Priority:

P2

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
WIP	webkit-ews: commit-queue-
WIP 2	buildbot: commit-queue-
WIP 3	none
patch	none

Mikhail Pozdnyakov

Reported 2013-05-06 08:01:42 PDT

HashTraits<RefPtr<P> >::PeekType should be raw pointer so that we can obviate multiple RefPtr copying when invoking HashMap::get() method (and when HashMap value type is RefPtr).

Attachments
WIP (23.78 KB, patch) 2013-05-06 08:04 PDT, Mikhail Pozdnyakov	webkit-ews: commit-queue-	Details Formatted Diff Diff
WIP 2 (29.25 KB, patch) 2013-05-06 09:11 PDT, Mikhail Pozdnyakov	buildbot: commit-queue-	Details Formatted Diff Diff
WIP 3 (29.85 KB, patch) 2013-05-06 09:55 PDT, Mikhail Pozdnyakov	no flags	Details Formatted Diff Diff
patch (37.34 KB, patch) 2013-05-06 11:18 PDT, Mikhail Pozdnyakov	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Mikhail Pozdnyakov

Comment 1 2013-05-06 08:04:51 PDT

Created attachment 200671 [details] WIP let's see what EWS tells.

Early Warning System Bot

Comment 2 2013-05-06 08:14:50 PDT

Comment on attachment 200671 [details] WIP Attachment 200671 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/378166

Early Warning System Bot

Comment 3 2013-05-06 08:18:11 PDT

Comment on attachment 200671 [details] WIP Attachment 200671 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/281086

Build Bot

Comment 4 2013-05-06 08:27:49 PDT

Comment on attachment 200671 [details] WIP Attachment 200671 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/278056

Build Bot

Comment 5 2013-05-06 08:34:55 PDT

Comment on attachment 200671 [details] WIP Attachment 200671 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/284026

Build Bot

Comment 6 2013-05-06 08:50:10 PDT

Comment on attachment 200671 [details] WIP Attachment 200671 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/289035

Mikhail Pozdnyakov

Comment 7 2013-05-06 09:11:20 PDT

Created attachment 200705 [details] WIP 2

Build Bot

Comment 8 2013-05-06 09:51:28 PDT

Comment on attachment 200705 [details] WIP 2 Attachment 200705 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/377201

Mikhail Pozdnyakov

Comment 9 2013-05-06 09:55:30 PDT

Created attachment 200714 [details] WIP 3

Mikhail Pozdnyakov

Comment 10 2013-05-06 11:18:17 PDT

Created attachment 200724 [details] patch

WebKit Commit Bot

Comment 11 2013-05-07 00:22:55 PDT

Comment on attachment 200724 [details] patch Clearing flags on attachment: 200724 Committed r149665: <http://trac.webkit.org/changeset/149665>

WebKit Commit Bot

Comment 12 2013-05-07 00:22:58 PDT

All reviewed patches have been landed. Closing bug.

Darin Adler

Comment 13 2013-05-26 18:10:55 PDT

*** Bug 72477 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.