Bug 115632 – REGRESSION (r149457): Multiple failures in subpixel-sensitive tests

• Component: WebKitGTK
• Status: RESOLVED INVALID

[Zan Dobersek]

The following four tests started failing after r149457:
fast/exclusions/shape-inside/shape-inside-polygon-layout.html
fast/exclusions/shape-outside-floats/shape-outside-floats-diamond-margin-polygon.html
fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-left.html
fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-right.html

http://trac.webkit.org/changeset/149457
http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fexclusions%2Fshape-inside%2Fshape-inside-polygon-layout.html%2Cfast%2Fexclusions%2Fshape-outside-floats%2Fshape-outside-floats-diamond-margin-polygon.html%2Cfast%2Fexclusions%2Fshape-outside-floats%2Fshape-outside-floats-ellipse-margin-left.html%2Cfast%2Fexclusions%2Fshape-outside-floats%2Fshape-outside-floats-ellipse-margin-right.html

Failures:

--- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/fast/exclusions/shape-inside/shape-inside-polygon-layout-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/fast/exclusions/shape-inside/shape-inside-polygon-layout-actual.txt
@@ -2,4 +2,8 @@
 X
 X
 X
+FAIL shapeInsideRect('a').top should be 7.109375. Was 7.
+FAIL shapeInsideRect('b').top should be 22.109375. Was 22.
+FAIL shapeInsideRect('c').top should be 37.109375. Was 37.
+FAIL shapeInsideRect('d').top should be 52.109375. Was 52.
 

--- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/fast/exclusions/shape-outside-floats/shape-outside-floats-diamond-margin-polygon-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/fast/exclusions/shape-outside-floats/shape-outside-floats-diamond-margin-polygon-actual.txt
@@ -6,15 +6,15 @@
 X
 X
 PASS elementRect('l1').top is 0
-PASS elementRect('l1').left is within 1 of 98
+PASS elementRect('l1').left is within 1 of 98.28125
 PASS elementRect('l2').top is 20
-PASS elementRect('l2').left is within 1 of 118
+PASS elementRect('l2').left is within 1 of 118.28125
 PASS elementRect('l3').top is 40
-PASS elementRect('l3').left is within 1 of 138
+FAIL elementRect('l3').left should be within 1 of 138.28125. Was 137.
 PASS elementRect('l4').top is 80
-PASS elementRect('l4').left is within 1 of 138
+FAIL elementRect('l4').left should be within 1 of 138.28125. Was 137.
 PASS elementRect('l5').top is 100
-PASS elementRect('l5').left is within 1 of 118
+PASS elementRect('l5').left is within 1 of 118.28125
 PASS elementRect('l6').top is 120
-PASS elementRect('l6').left is within 1 of 98
+PASS elementRect('l6').left is within 1 of 98.28125
 

--- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-left-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-left-actual.txt
@@ -4,6 +4,9 @@
 X
 X
 PASS elementRect('s1').top is 0
+FAIL elementRect('s1').left should be 347.078125. Was 347.
 PASS elementRect('s2').top is 20
+FAIL elementRect('s2').left should be 389.96875. Was 390.
 PASS elementRect('s3').top is 40
+FAIL elementRect('s3').left should be 417.171875. Was 417.
 

--- /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-right-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release/build/layout-test-results/fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-right-actual.txt
@@ -4,6 +4,9 @@
 X
 X
 PASS elementRect('s1').top is 0
+FAIL elementRect('s1').right should be 152.90625. Was 152.
 PASS elementRect('s2').top is 20
+FAIL elementRect('s2').right should be 110.015625. Was 110.
 PASS elementRect('s3').top is 40
+FAIL elementRect('s3').right should be 82.8125. Was 82.

[Bem Jones-Bey]

Hey Hans, were these tests on your list?

[Zoltan Horvath]

All the tests are passing now. Credits for double checking: Zan and Hans!
Closing bug as invalid.