Bug 115628

Summary: [GTK][WK1] Add an empty BatteryClientGtk
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 95582, 125453    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Zan Dobersek
Reported 2013-05-06 02:26:41 PDT
[GTK][WK1] Add an empty BatteryClientGtk
Attachments
Patch (6.63 KB, patch)
2013-05-06 02:34 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (6.75 KB, patch)
2013-05-07 03:34 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (6.65 KB, patch)
2013-11-06 03:58 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (1.72 KB, patch)
2013-12-09 07:40 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (6.64 KB, patch)
2013-12-09 08:09 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2013-05-06 02:34:59 PDT
Created attachment 200648 [details] Patch
Zan Dobersek
Comment 2 2013-05-07 03:34:00 PDT
Created attachment 200887 [details] Patch
Zan Dobersek
Comment 3 2013-05-14 11:08:17 PDT
This is ready for review. While the introduced BatteryClientGtk is not operational at all, it still isn't actually used until the Battery Status API support is enabled, so this is safe to land even before the feature is enabled.
Zan Dobersek
Comment 4 2013-11-06 03:58:05 PST
Created attachment 216161 [details] Patch Rebased patch.
Zan Dobersek
Comment 5 2013-12-09 07:40:17 PST
Created attachment 218762 [details] Patch Rebased patch.
Zan Dobersek
Comment 6 2013-12-09 07:41:07 PST
Comment on attachment 218762 [details] Patch Not the right patch.
Zan Dobersek
Comment 7 2013-12-09 08:09:04 PST
Created attachment 218763 [details] Patch Rebased patch.
Zan Dobersek
Comment 8 2013-12-11 08:43:13 PST
Comment on attachment 218763 [details] Patch Clearing flags on attachment: 218763 Committed r160437: <http://trac.webkit.org/changeset/160437>
Zan Dobersek
Comment 9 2013-12-11 08:43:21 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.