Summary: | [SH4] Misc bugfix and cleaning in sh4 base JIT | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Julien Brianceau <jbriance> | ||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, fpizlo, mark.lam, oliver | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Julien Brianceau
2013-05-06 02:18:21 PDT
Created attachment 200650 [details]
Misc bugfix and cleaning in sh4 base JIT
Attachment 200650 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/assembler/MacroAssemblerSH4.h', u'Source/JavaScriptCore/assembler/SH4Assembler.h']" exit_code: 1
Source/JavaScriptCore/assembler/SH4Assembler.h:118: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #2) > Source/JavaScriptCore/assembler/SH4Assembler.h:118: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] All other 100+ entries in this enum are in capital letters, so I think I'll leave it as it is. Also, I didn't see any regression when testing this patch with: - Tools/Scripts/run-javascriptcore-tests - Tools/Scripts/run-fast-jsc Comment on attachment 200650 [details] Misc bugfix and cleaning in sh4 base JIT View in context: https://bugs.webkit.org/attachment.cgi?id=200650&action=review > Source/JavaScriptCore/assembler/MacroAssemblerSH4.h:673 > + RegisterID scr = (dest == base) ? claimScratch() : dest; This seems common enough that you may want to make a function to do it automagically - getScratch(dest, base) or something? (In reply to comment #4) > (From update of attachment 200650 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=200650&action=review > > > Source/JavaScriptCore/assembler/MacroAssemblerSH4.h:673 > > + RegisterID scr = (dest == base) ? claimScratch() : dest; > > This seems common enough that you may want to make a function to do it automagically - getScratch(dest, base) or something? Yes, but in this case I'd also have to make an equivalent "releaseScratch(scr, dest, base)" function. This last one would be a little weird, don't you think? Comment on attachment 200650 [details] Misc bugfix and cleaning in sh4 base JIT Clearing flags on attachment: 200650 Committed r149634: <http://trac.webkit.org/changeset/149634> All reviewed patches have been landed. Closing bug. |