Bug 11562

Summary:

Fixing build of Qt/KDE platforms

Product:

WebKit

Reporter:

Zack Rusin <zack>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

420+

Hardware:

OS:

Linux

Attachments:

Description	Flags
fix the build	none
this one makes it compile, link and work	andersca: review+
fixed capitalization of macro guards	andersca: review+

Zack Rusin

Reported 2006-11-10 05:09:16 PST

After the recent changes Qt/KDE code was broken. The attached patch makes it build. Due to not implemented FrameLoaderClient it won't work but at least it builds.

Attachments
fix the build (61.09 KB, patch) 2006-11-10 05:09 PST, Zack Rusin	no flags	Details Formatted Diff Diff
this one makes it compile, link and work (85.11 KB, patch) 2006-11-10 08:33 PST, Zack Rusin	andersca: review+	Details Formatted Diff Diff
fixed capitalization of macro guards (85.12 KB, patch) 2006-11-10 11:10 PST, Zack Rusin	andersca: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Zack Rusin

Comment 1 2006-11-10 05:09:47 PST

Created attachment 11459 [details] fix the build

Zack Rusin

Comment 2 2006-11-10 08:33:34 PST

Created attachment 11462 [details] this one makes it compile, link and work i demand declerations of love for this one

Anders Carlsson

Comment 3 2006-11-10 11:07:38 PST

Comment on attachment 11462 [details] this one makes it compile, link and work r=me assuming you fix the capitalization in the preprocessor directives.

Zack Rusin

Comment 4 2006-11-10 11:10:30 PST

Created attachment 11463 [details] fixed capitalization of macro guards

Anders Carlsson

Comment 5 2006-11-10 11:25:08 PST

Comment on attachment 11463 [details] fixed capitalization of macro guards r=me

Mark Rowe (bdash)

Comment 6 2006-11-10 18:47:42 PST

Landed by Anders in r17703.

Note You need to log in before you can comment on or make changes to this bug.