Bug 115590

Summary:

Reoptimize free-standing :focus/link/visited/-webkit-any-link selectors.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

CSS

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

allan.jensen, buildbot, commit-queue, esprehn+autocc, glenn, koivisto, macpherson, menard, rniwa

Priority:

Keywords:

Performance

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2	none
how about this?	darin: review+

Andreas Kling

Reported 2013-05-04 09:52:45 PDT

Reoptimize free-standing :focus/link/visited/-webkit-any-link selectors.

Attachments
Patch (3.27 KB, patch) 2013-05-04 09:53 PDT, Andreas Kling	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 (1.27 MB, application/zip) 2013-05-04 11:47 PDT, Build Bot	no flags	Details
how about this? (2.38 KB, patch) 2013-05-09 11:19 PDT, Antti Koivisto	darin: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Andreas Kling

Comment 1 2013-05-04 09:53:20 PDT

Created attachment 200532 [details] Patch

Build Bot

Comment 2 2013-05-04 11:47:17 PDT

Comment on attachment 200532 [details] Patch Attachment 200532 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/332820 New failing tests: mathml/presentation/fractions.xhtml mathml/presentation/mo.xhtml mathml/presentation/mo-stretch.html mathml/presentation/attributes.xhtml mathml/presentation/row-alignment.xhtml mathml/presentation/subsup.xhtml mathml/presentation/fractions-vertical-alignment.xhtml mathml/presentation/over.xhtml fast/frames/crash-remove-iframe-during-object-beforeload.html mathml/presentation/roots.xhtml mathml/presentation/underover.xhtml

Build Bot

Comment 3 2013-05-04 11:47:18 PDT

Created attachment 200535 [details] Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.2

Andreas Kling

Comment 4 2013-05-04 13:22:12 PDT

Comment on attachment 200532 [details] Patch MathML why.

Antti Koivisto

Comment 5 2013-05-09 11:19:29 PDT

Created attachment 201255 [details] how about this?

Darin Adler

Comment 6 2013-05-09 11:21:17 PDT

Comment on attachment 201255 [details] how about this? Is there some good way to regression-test this so people don’t break it again? I know it can be hard to regression-test performance changes.

Antti Koivisto

Comment 7 2013-05-09 11:26:32 PDT

(In reply to comment #6) > (From update of attachment 201255 [details]) > Is there some good way to regression-test this so people don’t break it again? I know it can be hard to regression-test performance changes. I think this might even show up as progression in our regular tests. The change that broke this was a significant progression in itself and probably masked away the regression. We could definitely use better testing for things like this. Maybe debug only Internal API to record exact optimisations used?

Antti Koivisto

Comment 8 2013-05-09 13:35:02 PDT

http://trac.webkit.org/changeset/149838

Note You need to log in before you can comment on or make changes to this bug.