Summary: | StyleResolver: Have "list of matched rules" API vend internal types instead of CSSOM wrappers. | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||||||||||
Component: | CSS | Assignee: | Andreas Kling <kling> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | commit-queue, kling, koivisto, ossy, philn, webkit-ews, xan.lopez | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Bug Depends on: | 115855 | ||||||||||||||
Bug Blocks: | |||||||||||||||
Attachments: |
|
Description
Andreas Kling
2013-05-03 11:41:16 PDT
Created attachment 200446 [details]
Patch
Comment on attachment 200446 [details] Patch Attachment 200446 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/384528 Comment on attachment 200446 [details] Patch Attachment 200446 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/337526 Created attachment 200450 [details]
Patch v2
Try to fix Qt build.
Comment on attachment 200450 [details] Patch v2 Attachment 200450 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/332540 Comment on attachment 200450 [details] Patch v2 Attachment 200450 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/384534 Created attachment 200454 [details]
Patch v3
why qt why
Comment on attachment 200454 [details] Patch v3 Attachment 200454 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/266028 Created attachment 200455 [details]
Patch v4
why is programming hard.
r=me Comment on attachment 200455 [details] Patch v4 Rejecting attachment 200455 [details] from commit-queue. New failing tests: http/tests/security/cross-origin-getMatchedCSSRules.html http/tests/security/cross-origin-getMatchedCSSRules2.html fast/dom/Window/getMatchedCSSRules-with-invalid-pseudo-elements.html fast/dom/StyleSheet/detached-parent-rule-without-wrapper.html fast/css/modify-ua-rules-from-javascript.html Full output: http://webkit-queues.appspot.com/results/333579 Created attachment 200465 [details]
Archive of layout-test-results from webkit-cq-01 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-01 Port: mac-mountainlion Platform: Mac OS X 10.8.3
Committed r149532: <http://trac.webkit.org/changeset/149532> (In reply to comment #13) > Committed r149532: <http://trac.webkit.org/changeset/149532> FYI: It caused a serious regression - https://bugs.webkit.org/show_bug.cgi?id=115855 |