Summary: | [BlackBerry] GraphicsContext: add missing definitions. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alberto Garcia <berto> | ||||
Component: | WebKit BlackBerry | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cgarcia, commit-queue, xan.lopez | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 111729 | ||||||
Attachments: |
|
Description
Alberto Garcia
2013-05-02 06:54:59 PDT
Created attachment 200312 [details]
Patch
Comment on attachment 200312 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=200312&action=review > Source/WebCore/platform/graphics/blackberry/GraphicsContextBlackBerry.cpp:26 > +#include "RoundedRect.h" Are you sure we need this? (In reply to comment #2) > > Source/WebCore/platform/graphics/blackberry/GraphicsContextBlackBerry.cpp:26 > > +#include "RoundedRect.h" > > Are you sure we need this? Well, there's calls to RoundedRect::rect() and RoundedRect::radii() in that file. Why wouldn't we need it? Comment on attachment 200312 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=200312&action=review >> Source/WebCore/platform/graphics/blackberry/GraphicsContextBlackBerry.cpp:26 >> +#include "RoundedRect.h" > > Are you sure we need this? We do not use this internally so I think you should remove it from the patch. (In reply to comment #4) > >> +#include "RoundedRect.h" > > We do not use this internally so I think you should remove it from > the patch. But that's because we have that internally in Path.h, which I believe is unnecessary. I still think this is the best option because I don't see us including RoundRect.h from Path.h Or do you have any other suggestion? Comment on attachment 200312 [details]
Patch
Requesting review again based on my previous comments.
Comment on attachment 200312 [details]
Patch
Patch is fine but please check if we need the GraphicsContextBlackBerry.cpp change.
Comment on attachment 200312 [details] Patch Clearing flags on attachment: 200312 Committed r150820: <http://trac.webkit.org/changeset/150820> All reviewed patches have been landed. Closing bug. |