Bug 115485

Summary: TextTrackMenu crashes in ports where MediaElement players are lazily created
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: MediaAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, esprehn+autocc, glenn, jer.noble
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2013-05-01 12:20:25 PDT
iOS is a port that lazily creates its player. HTMLMediaElement frequently null checks m_player, but doesn't in the PLATFORM_TEXT_TRACK_MENU code. We should add the null checks.
Attachments
[PATCH] Proposed Fix (1.63 KB, patch)
2013-05-01 12:22 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2013-05-01 12:22:03 PDT
Created attachment 200234 [details] [PATCH] Proposed Fix
Eric Carlson
Comment 2 2013-05-01 12:27:07 PDT
Comment on attachment 200234 [details] [PATCH] Proposed Fix Thanks!
WebKit Commit Bot
Comment 3 2013-05-01 12:54:34 PDT
Comment on attachment 200234 [details] [PATCH] Proposed Fix Clearing flags on attachment: 200234 Committed r149447: <http://trac.webkit.org/changeset/149447>
WebKit Commit Bot
Comment 4 2013-05-01 12:54:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.