Bug 115480

Summary:

Add FunctionDispatcher class and make RunLoop derive from it

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cmarcelo, commit-queue, eflews.bot, gyuyoung.kim, gyuyoung.kim, philn, rakuco, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	sam: review+

Anders Carlsson

Reported 2013-05-01 10:44:57 PDT

Add FunctionDispatcher class and make RunLoop derive from it

Attachments
Patch (12.91 KB, patch) 2013-05-01 10:47 PDT, Anders Carlsson	no flags	Details Formatted Diff Diff
Patch (13.48 KB, patch) 2013-05-01 10:56 PDT, Anders Carlsson	no flags	Details Formatted Diff Diff
Patch (15.39 KB, patch) 2013-05-01 11:13 PDT, Anders Carlsson	no flags	Details Formatted Diff Diff
Patch (14.10 KB, patch) 2013-05-01 11:18 PDT, Anders Carlsson	sam: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Anders Carlsson

Comment 1 2013-05-01 10:47:07 PDT

Created attachment 200221 [details] Patch

WebKit Commit Bot

Comment 2 2013-05-01 10:48:51 PDT

Attachment 200221 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/WTF.pro', u'Source/WTF/WTF.vcproj/WTF.vcproj', u'Source/WTF/WTF.vcxproj/WTF.vcxproj', u'Source/WTF/WTF.xcodeproj/project.pbxproj', u'Source/WTF/wtf/FunctionDispatcher.cpp', u'Source/WTF/wtf/FunctionDispatcher.h', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/RunLoop.h']" exit_code: 1 Source/WTF/wtf/FunctionDispatcher.h:35: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.

Anders Carlsson

Comment 3 2013-05-01 10:56:15 PDT

Created attachment 200224 [details] Patch

WebKit Commit Bot

Comment 4 2013-05-01 10:58:45 PDT

Attachment 200224 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/GNUmakefile.list.am', u'Source/WTF/WTF.pro', u'Source/WTF/WTF.vcproj/WTF.vcproj', u'Source/WTF/WTF.vcxproj/WTF.vcxproj', u'Source/WTF/WTF.xcodeproj/project.pbxproj', u'Source/WTF/wtf/FunctionDispatcher.cpp', u'Source/WTF/wtf/FunctionDispatcher.h', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/RunLoop.h']" exit_code: 1 Source/WTF/wtf/FunctionDispatcher.h:35: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.

EFL EWS Bot

Comment 5 2013-05-01 11:05:29 PDT

Comment on attachment 200224 [details] Patch Attachment 200224 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/369080

Anders Carlsson

Comment 6 2013-05-01 11:13:47 PDT

Created attachment 200227 [details] Patch

Anders Carlsson

Comment 7 2013-05-01 11:18:14 PDT

Created attachment 200228 [details] Patch

WebKit Commit Bot

Comment 8 2013-05-01 11:19:08 PDT

Attachment 200228 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/GNUmakefile.list.am', u'Source/WTF/WTF.pro', u'Source/WTF/WTF.vcproj/WTF.vcproj', u'Source/WTF/WTF.vcxproj/WTF.vcxproj', u'Source/WTF/WTF.xcodeproj/project.pbxproj', u'Source/WTF/wtf/CMakeLists.txt', u'Source/WTF/wtf/FunctionDispatcher.cpp', u'Source/WTF/wtf/FunctionDispatcher.h', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/RunLoop.h']" exit_code: 1 Source/WTF/wtf/FunctionDispatcher.h:35: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.

Sam Weinig

Comment 9 2013-05-01 11:27:56 PDT

Comment on attachment 200228 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=200228&action=review > Source/WTF/wtf/FunctionDispatcher.h:32 > +class FunctionDispatcher : public ThreadSafeRefCounted<FunctionDispatcher> { > +public: I think this is abstract enough that it could use a comment explaining its use.

Anders Carlsson

Comment 10 2013-05-01 11:58:23 PDT

Committed r149444: <http://trac.webkit.org/changeset/149444>

Note You need to log in before you can comment on or make changes to this bug.