Bug 115478

Summary: Incorrect layout for blocks containing ideographs with -webkit-linebox-contain: glyphs, font, inline-box
Product: WebKit Reporter: Enrica Casucci <enrica>
Component: Layout and RenderingAssignee: Enrica Casucci <enrica>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, hyatt
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: Unspecified   
Attachments:
Description Flags
Test case
none
Patch hyatt: review+

Enrica Casucci
Reported 2013-05-01 10:26:39 PDT
Open the attached test case. You'll see that the second glyph in each box is off to the side. <rdar://problem/13568906>
Attachments
Test case (660 bytes, application/xhtml+xml)
2013-05-01 10:27 PDT, Enrica Casucci 		no flags
Details
Patch (69.51 KB, patch)
2013-05-01 10:49 PDT, Enrica Casucci 		hyatt: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Enrica Casucci
Comment 1 2013-05-01 10:27:17 PDT
Created attachment 200219 [details] Test case
Enrica Casucci
Comment 2 2013-05-01 10:28:09 PDT
I discussed this problem with Hyatt and he figured out where the bug is. In RootInlineBox::ascentAndDescentForBox there are cases where we compute ascent and descent without passing the baseline type which causes an incorrect computation in case of ideographs.
Enrica Casucci
Comment 3 2013-05-01 10:49:31 PDT
Created attachment 200223 [details] Patch
Dave Hyatt
Comment 4 2013-05-01 13:23:04 PDT
Comment on attachment 200223 [details] Patch r=me
Enrica Casucci
Comment 5 2013-05-01 13:36:20 PDT
Committed revision 149450.
Note You need to log in before you can comment on or make changes to this bug.