Bug 115471

Summary: [Mac] Text replacement should use correction indicator
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, ddavidso, enrica, jiapu.mail
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fixes the bug
none
Removed tab characters darin: review+

Ryosuke Niwa
Reported 2013-05-01 03:02:02 PDT
We should use correction panel for text replacement just like we do for autocorrection. <rdar://problem/13664799>
Attachments
Fixes the bug (3.01 KB, patch)
2013-05-01 03:27 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Removed tab characters (3.04 KB, patch)
2013-05-01 12:16 PDT, Ryosuke Niwa 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2013-05-01 03:27:07 PDT
Created attachment 200210 [details] Fixes the bug
WebKit Commit Bot
Comment 2 2013-05-01 03:28:36 PDT
Attachment 200210 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/editing/AlternativeTextController.cpp', u'Source/WebCore/editing/Editor.cpp']" exit_code: 1 Source/WebCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:12: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:16: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:20: Line contains tab character. [whitespace/tab] [5] Total errors found: 5 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ryosuke Niwa
Comment 3 2013-05-01 12:16:27 PDT
Created attachment 200233 [details] Removed tab characters
Ryosuke Niwa
Comment 4 2013-05-01 17:01:49 PDT
Committed in http://trac.webkit.org/changeset/149465.
Note You need to log in before you can comment on or make changes to this bug.