|Summary:||Disable the old testcases do not follow the ECMA-262v3 specification.|
|OS:||OS X 10.4|
Description digdog 2006-11-08 08:01:03 PST
Comment 2 Maciej Stachowiak 2006-11-10 03:06:21 PST
IT's great to disable the failing tests! However, I suggest adding a comment below each removed test explaining why it is invalid. Also, and more importantly, your new expected results seem to contain new failures. I don't think we want to land that. r- for improper new expected results. It seems to be a date issue, maybe fixed now.
Comment 3 digdog 2006-11-10 06:07:50 PST
Comment 4 digdog 2006-11-10 06:22:59 PST
Comment 5 digdog 2006-11-10 06:36:53 PST
Comment 6 digdog 2006-11-10 06:41:04 PST
"r- for improper new expected results." Sorry, but what does this mean? I don't get "r-"...
Comment 8 digdog 2006-11-11 06:19:58 PST
expected result updated.
Comment 9 digdog 2006-11-12 09:11:32 PST
Comment on attachment 11486 [details] patch.txt remove patch due non-PST timezone regression appeared (http://bugs.webkit.org/show_bug.cgi?id=4930)
Comment 10 digdog 2006-11-12 09:28:44 PST
Created attachment 11499 [details] patch.txt update expected results.
Comment 11 Darin Adler 2006-12-07 15:36:46 PST
Comment on attachment 11499 [details] patch.txt This patch looks fine to me, but I'd prefer to see a comment explaining why these tests are disabled instead of just having the tests commented out without explanation.
Comment 12 Darin Adler 2006-12-07 15:39:06 PST
Comment on attachment 11499 [details] patch.txt I'll mark this review+, but it would be even better with the comments.
Comment 13 Mark Rowe (bdash) 2006-12-07 16:30:42 PST
digdog, can you please update your patch with the comments that Darin noted so that it can more easily be landed?