|Summary:||Port of WebKit ToT to S60|
|Severity:||Normal||CC:||bradley.morrison, dacarson, koivisto, mrowe, roland.geisler, Sachin.Padma, yongjun.zhang|
Description zalan 2006-11-07 11:21:29 PST
This bug brings S60 to WebKit ToT.
Comment 1 zalan 2006-11-07 12:56:02 PST
Created attachment 11417 [details] contains basic types like point, rect, size and string on symbian platform
Comment 2 zalan 2006-11-07 15:18:03 PST
Created attachment 11418 [details] platform/PlatformString.h changes were missing from the prev patch
Comment 3 Maciej Stachowiak 2006-11-07 22:02:24 PST
Comment 4 Antti Koivisto 2006-11-08 09:13:49 PST
No, Symbian does not have valloc() or anything similar. There is no easy way to do page aligned allocations as far as I can find out.
Comment 5 Yongjun Zhang 2006-11-08 09:32:06 PST
valloc is not internal supported by Symbian. The good news is that we are going to use dlmalloc to replace Symbian's default allocator, and we can simulate page-aligned memory allocation by using dlvalloc.
Comment 6 zalan 2006-11-08 10:21:30 PST
yes, i think we can submit the patch without the patentlicense.txt. Nokia uses this modified BSD license text throughout its (BSD)open source contribution but I will check with the legal department whether that is something we can change for WebKit. Do you think if you could land the code with the current license header as the legal check could take a while and i really don't want to block commits just because of that?
Comment 7 zalan 2006-11-09 12:15:33 PST
Created attachment 11444 [details] basic types for Symbian platform -lowercase symbian dir -moved byte alignment comment from .h to WebCore/Changlog -removed WebKitS60 dir -haven't received anything back on the modified BSD header so this patch has the same header as the previous patch had (except the removed patentlicense text)
Comment 8 Maciej Stachowiak 2006-11-10 03:33:55 PST
OK, the code changes all look great, let me check on the license on our end.
Comment 9 Maciej Stachowiak 2006-11-10 14:44:01 PST
License is fine too. r=me. Yay for the first S60 merge patch!