Summary: | REGRESSION(r149287): Assertion failure in fast/frames/flattening/iframe-flattening-crash.html | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||||
Component: | Frames | Assignee: | Andreas Kling <kling> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, ggaren, kling, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar, LayoutTestFailure | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 115476 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Alexey Proskuryakov
2013-04-29 16:46:45 PDT
Actually, maybe all Mac ones, wk1 or wk2. E.g.<http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r149322%20(9330)/fast/frames/flattening/iframe-flattening-crash-crash-log.txt>. Skipped on Mac in http://trac.webkit.org/r149333 Re-entrant layout is definitely a no-no. This could cause lots of serious problems. Created attachment 200132 [details]
Proposed patch
Attachment 200132 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/mac/TestExpectations', u'Source/WebCore/ChangeLog', u'Source/WebCore/page/EventHandler.cpp', u'Source/WebCore/page/EventHandler.h', u'Source/WebCore/page/FrameView.cpp']" exit_code: 1
Source/WebCore/page/FrameView.cpp:38: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r149382: <http://trac.webkit.org/changeset/149382> Re-opened since this is blocked by bug 115476 Created attachment 200217 [details]
Follow-up patch
Because I am a muppet who only tested the previous patch with a release build, it kept on failing in debug.
This patch changes limits synchronous resize events to the main frame.
Comment on attachment 200217 [details] Follow-up patch View in context: https://bugs.webkit.org/attachment.cgi?id=200217&action=review r=me > Source/WebCore/page/FrameView.cpp:2792 > + bool isMainFrame = page ? page->mainFrame() == m_frame : false; page && page->mainFrame() == m_frame ? Is the test still skipped in TestExpectations? (In reply to comment #11) > Is the test still skipped in TestExpectations? It is not skipped. Committed r149435: <http://trac.webkit.org/changeset/149435> |