Bug 115366 – WEB SPEECH: need to identify the default voice per language

• Component: Accessibility
• Status: RESOLVED FIXED

[chris fleizach]

We need a way on the Mac platform to identify which voice for a language is the default

[chris fleizach]

Created attachment 200062 [details]
patch

[chris fleizach]

Adding Tim to help with review

[Tim Horton]

Comment on attachment 200062 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=200062&action=review

> Source/WebCore/platform/mac/PlatformSpeechSynthesizerMac.mm:109
> +                // When we find the default voice for this language we can stop, but until then we have to keep searching.

Not sure this comment is useful, it's just describing exactly what the code already tells us.

[chris fleizach]

(In reply to comment #3)
> (From update of attachment 200062 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=200062&action=review
> 
> > Source/WebCore/platform/mac/PlatformSpeechSynthesizerMac.mm:109
> > +                // When we find the default voice for this language we can stop, but until then we have to keep searching.
> 
> Not sure this comment is useful, it's just describing exactly what the code already tells us.

Nixed. Thanks

[chris fleizach]

http://trac.webkit.org/changeset/149342

[Tim Horton]

Hey, Chris, can you land the updated WKSI library? You've broken the open-source mac build, I think.

[chris fleizach]

(In reply to comment #6)
> Hey, Chris, can you land the updated WKSI library? You've broken the open-source mac build, I think.

Damn sorry. On it

[chris fleizach]

(In reply to comment #7)
> (In reply to comment #6)
> > Hey, Chris, can you land the updated WKSI library? You've broken the open-source mac build, I think.
> 
> Damn sorry. On it

Hmm. Are you sure? I don't see a build failure in waterfall, but my latest change for this only changed the implementation of WKSI. 

When I do an WKSI update, I see these updates ready to stage

 void WKCFURLRequestSetHTTPRequestBodyParts(CFMutableURLRequestRef, CFArrayRef bodyParts);
 
 void WKSetVisibleApplicationName(CFStringRef);
+void WKSetApplicationInformationItem(CFStringRef key, CFTypeRef value);
 
 CFURLRef WKCopyBundleURLForExecutableURL(CFURLRef);
 
@@ -494,7 +495,10 @@
 bool WKUnregisterOcclusionNotificationHandler(WKOcclusionNotificationType, WKOcclusionNotificationHandler);
 bool WKEnableWindowOcclusionNotifications(NSInteger windowID, bool *outCurrentOcclusionState);
 
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wdeprecated-declarations"
 extern const NSSystemBehaviors WKProcessSuppressionSystemBehaviors;
+#pragma clang diagnostic pop
 #endif
 
 bool WKIsJavaPlugInActive(void);


Are those causing the problems?

[Tim Horton]

(In reply to comment #8)
> (In reply to comment #7)
> > (In reply to comment #6)
> > > Hey, Chris, can you land the updated WKSI library? You've broken the open-source mac build, I think.
> > 
> > Damn sorry. On it
> 
> Hmm. Are you sure? I don't see a build failure in waterfall, but my latest change for this only changed the implementation of WKSI. 

I don't see it on the bots either, but I see it locally building just Open Source on Mountain Lion.

It looks like you did add "SpeechSynthesisGetDefaultVoiceIdentifierForLocale" here, and that's the one it's complaining about.

> When I do an WKSI update, I see these updates ready to stage
> 
>  void WKCFURLRequestSetHTTPRequestBodyParts(CFMutableURLRequestRef, CFArrayRef bodyParts);
> 
>  void WKSetVisibleApplicationName(CFStringRef);
> +void WKSetApplicationInformationItem(CFStringRef key, CFTypeRef value);
> 
>  CFURLRef WKCopyBundleURLForExecutableURL(CFURLRef);
> 
> @@ -494,7 +495,10 @@
>  bool WKUnregisterOcclusionNotificationHandler(WKOcclusionNotificationType, WKOcclusionNotificationHandler);
>  bool WKEnableWindowOcclusionNotifications(NSInteger windowID, bool *outCurrentOcclusionState);
> 
> +#pragma clang diagnostic push
> +#pragma clang diagnostic ignored "-Wdeprecated-declarations"
>  extern const NSSystemBehaviors WKProcessSuppressionSystemBehaviors;
> +#pragma clang diagnostic pop
>  #endif
> 
>  bool WKIsJavaPlugInActive(void);
> 
> 
> Are those causing the problems?

Hmmmm, not sure what's up. I think someone already updated those yesterday. I'll look more tomorrow.