Bug 115293

Summary:

delete-stale-build-files does not clear .d files

Product:

WebKit

Reporter:

Vicki Pfau <jeffrey+webkit>

Component:

Tools / Tests

Assignee:

Vicki Pfau <jeffrey+webkit>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

thorton

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	rniwa: review+

Vicki Pfau

Reported 2013-04-26 17:16:29 PDT

Empty .d files can be generated sometimes when a build goes bad. We should clean up those files.

Attachments
Patch (1.29 KB, patch) 2013-04-26 17:18 PDT, Vicki Pfau	rniwa: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Vicki Pfau

Comment 1 2013-04-26 17:18:38 PDT

Created attachment 199878 [details] Patch

Tim Horton

Comment 2 2013-04-26 17:20:12 PDT

Have you checked to make sure that running this on a good build doesn't cause any extraneous rebuilding on a subsequent build?

Vicki Pfau

Comment 3 2013-04-26 17:47:33 PDT

(In reply to comment #2) > Have you checked to make sure that running this on a good build doesn't cause any extraneous rebuilding on a subsequent build? It does not appear to affect build times on a good build at all.

Vicki Pfau

Comment 4 2013-04-26 17:50:21 PDT

Committed r149228: <http://trac.webkit.org/changeset/149228>

Note You need to log in before you can comment on or make changes to this bug.