Bug 115286

Summary:

IndexingTypes should use hex

Product:

WebKit

Reporter:

Mark Hahnenberg <mhahnenberg>

Component:

JavaScriptCore

Assignee:

Mark Hahnenberg <mhahnenberg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion	none
Patch	none

Mark Hahnenberg

Reported 2013-04-26 16:18:30 PDT

Decimal is kind of confusing/hard to read because they're used as bit masks. Hex seems more appropriate.

Attachments
Patch (2.95 KB, patch) 2013-04-26 17:49 PDT, Mark Hahnenberg	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (1015.46 KB, application/zip) 2013-04-26 23:28 PDT, Build Bot	no flags	Details
Patch (2.93 KB, patch) 2013-04-27 14:05 PDT, Mark Hahnenberg	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Mark Hahnenberg

Comment 1 2013-04-26 17:49:28 PDT

Created attachment 199880 [details] Patch

Geoffrey Garen

Comment 2 2013-04-26 18:20:21 PDT

Comment on attachment 199880 [details] Patch r=me

Build Bot

Comment 3 2013-04-26 23:28:39 PDT

Comment on attachment 199880 [details] Patch Attachment 199880 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/21512 New failing tests: css3/filters/custom/custom-filter-transforms-animation.html http/tests/inspector/change-iframe-src.html http/tests/inspector/console-resource-errors.html fast/harness/user-preferred-language.html fast/dom/NodeList/nodelist-item-assignment.html css3/masking/clip-path-animation.html fast/exclusions/shape-inside/shape-inside-animation.html fast/js/Object-defineProperty.html fast/js/mozilla/strict/8.12.5.html fast/css/large-list-of-rules-crash.html animations/cross-fade-webkit-mask-box-image.html css3/filters/custom/custom-filter-animation.html fast/dom/Window/btoa-pnglet.html http/tests/inspector/compiler-script-mapping.html animations/cross-fade-list-style-image.html css3/filters/filter-animation-from-none-multi.html css3/filters/filter-animation-from-none.html css3/filters/filter-animation-from-none-multi-hw.html animations/cross-fade-background-image.html fast/forms/submit-to-blank-multiple-times.html animations/cross-fade-border-image-source.html css3/filters/filter-animation-from-none-hw.html css3/filters/composited-during-animation.html http/tests/inspector/console-xhr-logging-async.html css3/filters/custom/custom-filter-array-blending.html fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html animations/cross-fade-webkit-mask-image.html fast/loader/javascript-url-in-object.html editing/selection/move-left-right.html fast/css/getComputedStyle/getComputedStyle-transform.html

Build Bot

Comment 4 2013-04-26 23:28:40 PDT

Created attachment 199895 [details] Archive of layout-test-results from webkit-ews-06 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.2

Mark Hahnenberg

Comment 5 2013-04-27 14:05:33 PDT

Created attachment 199915 [details] Patch

Mark Hahnenberg

Comment 6 2013-04-27 14:06:31 PDT

Re-uploaded because apparently I'm bad at doing decimal-to-hex conversions in my head.

Geoffrey Garen

Comment 7 2013-04-27 15:40:57 PDT

Comment on attachment 199915 [details] Patch r=me

WebKit Commit Bot

Comment 8 2013-04-29 12:07:35 PDT

Comment on attachment 199915 [details] Patch Clearing flags on attachment: 199915 Committed r149304: <http://trac.webkit.org/changeset/149304>

WebKit Commit Bot

Comment 9 2013-04-29 12:07:37 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.