Bug 115262

Summary:

EventSource: some invalid retry field values are not ignored

Product:

WebKit

Reporter:

Per-Erik Brodin <per-erik.brodin>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

UNCONFIRMED

Severity:

Normal

CC:

ahmad.saleem792, annevk, ap, mike

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	darin: review+

Per-Erik Brodin

Reported 2013-04-26 09:04:52 PDT

According to the EventSource specification, 'retry' field values that consist of characters other than ASCII digits should be ignored. Both Firefox and Opera (Presto) seem to do this correctly.

Attachments
patch (5.02 KB, patch) 2013-04-26 09:12 PDT, Per-Erik Brodin	darin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Per-Erik Brodin

Comment 1 2013-04-26 09:12:05 PDT

Created attachment 199839 [details] patch

Alexey Proskuryakov

Comment 2 2013-04-26 09:44:03 PDT

Comment on attachment 199839 [details] patch Would charactersToUInt64Strict() work here? From a quick glance at that function, it appears to only allow leading and trailing spaces, which should be fine when parsing an HTTP response, I think.

Per-Erik Brodin

Comment 3 2013-04-26 10:19:07 PDT

(In reply to comment #2) > (From update of attachment 199839 [details]) > Would charactersToUInt64Strict() work here? From a quick glance at that function, it appears to only allow leading and trailing spaces, which should be fine when parsing an HTTP response, I think. I considered that one, but I think it's not strict enough for spec compliance since, in addition to leading and trailing spaces, for example +5000 would also be allowed.

Note You need to log in before you can comment on or make changes to this bug.