Bug 115215

Summary: Use push and pop for iOS math function thunks
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, msaboff
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 115144    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Benjamin Poulain
Reported 2013-04-25 17:58:07 PDT
Use push and pop for iOS math function thunks
Attachments
Patch (1.84 KB, patch)
2013-04-25 18:00 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2013-04-25 18:00:36 PDT
Created attachment 199770 [details] Patch
Filip Pizlo
Comment 2 2013-04-27 15:17:00 PDT
Comment on attachment 199770 [details] Patch Did you test that calling printf() or similar from jsRound() for example, and then calling Math.round(), works without crashing?
Benjamin Poulain
Comment 3 2013-04-27 15:20:10 PDT
(In reply to comment #2) > (From update of attachment 199770 [details]) > Did you test that calling printf() or similar from jsRound() for example, and then calling Math.round(), works without crashing? I'll try that on Monday. I am pretty sure of the alignment on 4 bytes because I already accidentally ran into that when I wrote TransformationMatrix's optimizations. I assumed the stack would be at least aligned to 8 bytes when writing the VFP code, and that happily crashed in the tests.
Filip Pizlo
Comment 4 2013-04-27 15:21:08 PDT
Comment on attachment 199770 [details] Patch Would be good to do that test before landing. Otherwise, r=me.
Benjamin Poulain
Comment 5 2013-04-29 16:49:50 PDT
(In reply to comment #4) > (From update of attachment 199770 [details]) > Would be good to do that test before landing. Otherwise, r=me. I just tried on an Apple A5, no problem with printf called from jsRound.
Benjamin Poulain
Comment 6 2013-04-29 16:53:27 PDT
Comment on attachment 199770 [details] Patch Clearing flags on attachment: 199770 Committed r149331: <http://trac.webkit.org/changeset/149331>
Benjamin Poulain
Comment 7 2013-04-29 16:53:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.