Bug 115208

Summary: SuperRegion doesn't call deallocate() on its PageReservation
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 115227    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Description Mark Hahnenberg 2013-04-25 15:18:03 PDT 
It should. This doesn't cause us to leak physical memory, but it does cause us to leak virtual address space (and probably mach ports), which is also bad :-( FixedVMPoolExecutableAllocator also has this bug, but it doesn't matter much because there's only one instance of that class throughout the entire lifetime of the process, whereas each VM has its own SuperRegion.
Comment 1 Mark Hahnenberg 2013-04-25 15:29:09 PDT 
Created attachment 199759 [details]
Patch
Comment 2 Mark Hahnenberg 2013-04-25 15:30:31 PDT 
Created attachment 199760 [details]
Patch
Comment 3 Geoffrey Garen 2013-04-25 17:22:49 PDT 
Comment on attachment 199760 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2013-04-25 19:46:22 PDT 
Comment on attachment 199760 [details]
Patch

Clearing flags on attachment: 199760

Committed r149165: <http://trac.webkit.org/changeset/149165>
Comment 5 WebKit Commit Bot 2013-04-25 19:46:24 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Mark Hahnenberg 2013-04-25 20:18:11 PDT 
<rdar://problem/13745392>