Bug 115196

Summary:

webkitbot should recognize its own nickname in greetings.

Product:

WebKit

Reporter:

WebKit Commit Bot <commit-queue>

Component:

New Bugs

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

kling, menard, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Fixes the bug	kling: review+

Description WebKit Commit Bot 2013-04-25 12:28:08 PDT

webkitbot should recognize it's own nickname in greetings.
Requested by kling on #webkit.

Comment 1 Andreas Kling 2013-04-25 12:33:01 PDT

21:26:47 benjaminp: webkitbot_: hi webkitbot_!
21:26:52 webkitbot_: She, where he had had 'had', had had 'had had'. 'Had had' had had the approval of the examiner.

Horrible!

Comment 2 Alexis Menard (darktears) 2013-04-25 12:35:26 PDT

(In reply to comment #1)
> 21:26:47 benjaminp: webkitbot_: hi webkitbot_!
> 21:26:52 webkitbot_: She, where he had had 'had', had had 'had had'. 'Had had' had had the approval of the examiner.
> 
> Horrible!

Clearly lack of education.

Comment 3 Ryosuke Niwa 2013-04-25 12:41:35 PDT

Created attachment 199739 [details]
Fixes the bug

Comment 4 Andreas Kling 2013-04-25 12:42:41 PDT

Comment on attachment 199739 [details]
Fixes the bug

I'm ok with this.

Comment 5 Ryosuke Niwa 2013-04-25 12:43:40 PDT

Committed r149132: <http://trac.webkit.org/changeset/149132>