Thread safety issues in WKCustomProtocol

• Component: WebKit2
• Status: RESOLVED FIXED

[Brady Eidson]

Thread safety issues in WKCustomProtocol

WebKit2's custom protocol management needs to coordinate access to the m_customProtocolMap

In radar as <rdar://problem/13247304>

[Brady Eidson]

Created attachment 199681 [details]
Patch v1

[Alexey Proskuryakov]

Comment on attachment 199681 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=199681&action=review

r=me assuming WKCustomProtocol is ThreadSafeRefCounted.

> Source/WebKit2/Shared/Network/CustomProtocols/CustomProtocolManager.h:101
> +    RetainPtr<WKCustomProtocol> protocolForID(uint64_t customProtocolID);

I'd add a comment explaining the RetainPtr. Looking at it, I already foolishly want to remove it :)

[Brady Eidson]

(In reply to comment #2)
> (From update of attachment 199681 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=199681&action=review
> 
> r=me assuming WKCustomProtocol is ThreadSafeRefCounted.

It is - of course - an Obj-C class and therefore its Retain counting is thread safe.
> 
> > Source/WebKit2/Shared/Network/CustomProtocols/CustomProtocolManager.h:101
> > +    RetainPtr<WKCustomProtocol> protocolForID(uint64_t customProtocolID);
> 
> I'd add a comment explaining the RetainPtr. Looking at it, I already foolishly want to remove it :)

Indeed!

Thanks!

[Brady Eidson]

http://trac.webkit.org/changeset/149121