Bug 115179

Summary: Add support for Web IDL callback interfaces to the bindings generator
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Tools / TestsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, benjamin, commit-queue, eric.carlson, esprehn+autocc, haraken, hta, jer.noble, laszlo.gombos, rniwa, sam, tommyw
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://dev.w3.org/2006/webapi/WebIDL/#dfn-callback-interface
Attachments:
Description Flags
Patch none

Description Chris Dumez 2013-04-25 08:15:22 PDT 
Our bindings generator currently supports a Webkit-specific [Callback] extended attribute on interfaces instead of the standard Web IDL callback interfaces [1].

I believe it is a good idea to follow standard Web IDL for cases where a solution exists.

[1] http://dev.w3.org/2006/webapi/WebIDL/#dfn-callback-interface
Comment 1 Chris Dumez 2013-04-25 08:23:27 PDT 
Created attachment 199662 [details]
Patch
Comment 2 Kentaro Hara 2013-04-25 08:26:53 PDT 
Comment on attachment 199662 [details]
Patch

Thank you very much for keeping the IDL parser consistent between JSC and V8, and with the spec.
Comment 3 WebKit Commit Bot 2013-04-25 08:54:09 PDT 
Comment on attachment 199662 [details]
Patch

Clearing flags on attachment: 199662

Committed r149113: <http://trac.webkit.org/changeset/149113>
Comment 4 WebKit Commit Bot 2013-04-25 08:54:12 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Chris Dumez 2013-04-25 11:55:23 PDT 
I updated the WebKitIDL wiki accordingly:
https://trac.webkit.org/wiki/WebKitIDL?action=diff&version=86&old_version=85