Bug 115176

Summary: Web Inspector: Crash due to null items from getDOMStorageItems
Product: WebKit Reporter: Konrad Piascik <kpiascik>
Component: New BugsAssignee: Konrad Piascik <kpiascik>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, joepeck, kpiascik
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Konrad Piascik 2013-04-25 06:42:11 PDT
Web Inspector: Crash due to null items from getDOMStorageItems
Comment 1 Konrad Piascik 2013-04-25 07:22:47 PDT
This asserts in DEBUG builds as well
0x7cb22ec4 in WebCore::InspectorObjectBase::setValue (this=0x774bfcf8, name=..., value=...)
    at /home/kpiascik/dev/webkit/Source/WebCore/inspector/InspectorValues.h:336
336	    ASSERT(value);
(gdb) bt
#0  0x7cb22ec4 in WebCore::InspectorObjectBase::setValue (this=0x774bfcf8, name=..., value=...)
    at /home/kpiascik/dev/webkit/Source/WebCore/inspector/InspectorValues.h:336
#1  0x7d8e37f8 in WebCore::InspectorBackendDispatcherImpl::DOMStorage_getDOMStorageItems (this=0x7a046518, callId=62, 
    requestMessageObject=0x7760f0e0)
    at /home/kpiascik/dev/webkit/WebKitBuild/armle-v7/Debug/DerivedSources/WebCore/InspectorBackendDispatcher.cpp:2555
#2  0x7d8fb6cc in WebCore::InspectorBackendDispatcherImpl::dispatch (this=0x7a046518, message=...)
    at /home/kpiascik/dev/webkit/WebKitBuild/armle-v7/Debug/DerivedSources/WebCore/InspectorBackendDispatcher.cpp:6650
#3  0x7cba44ec in WebCore::InspectorController::dispatchMessageFromFrontend (this=0x799c8b48, message=...)
    at /home/kpiascik/dev/webkit/Source/WebCore/inspector/InspectorController.cpp:360
(gdb) up
#1  0x7d8e37f8 in WebCore::InspectorBackendDispatcherImpl::DOMStorage_getDOMStorageItems (this=0x7a046518, callId=62, 
    requestMessageObject=0x7760f0e0)
    at /home/kpiascik/dev/webkit/WebKitBuild/armle-v7/Debug/DerivedSources/WebCore/InspectorBackendDispatcher.cpp:2555
2555	            result->setValue("entries", out_entries);
(gdb) p out_entries
$1 = {m_ptr = 0x0}
Comment 2 Konrad Piascik 2013-04-26 06:11:15 PDT
Created attachment 199821 [details]
Patch
Comment 3 Joseph Pecoraro 2013-04-26 11:13:08 PDT
Comment on attachment 199821 [details]
Patch

Nice, good test.
Comment 4 WebKit Commit Bot 2013-04-26 11:56:34 PDT
Comment on attachment 199821 [details]
Patch

Clearing flags on attachment: 199821

Committed r149200: <http://trac.webkit.org/changeset/149200>
Comment 5 WebKit Commit Bot 2013-04-26 11:56:36 PDT
All reviewed patches have been landed.  Closing bug.