Bug 115154
| Summary: | Avoid using OverlapMap in RenderLayerCompositor::computeCompositingRequirements | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | ahmad.saleem792, hurnjoo.lee, simon.fraser, thorton |
| Priority: | P2 | Keywords: | BlinkMergeCandidate |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryosuke Niwa
We might want to back port https://chromium.googlesource.com/chromium/blink/+/d41b759196c8be22bea5ef0217e18dd4c171c05d
Do not use the OverlapMap in RenderLayerCompositor::computeCompositingRequirements if the layer already
has a 3D transform. This way we can avoid a potential expensive lookup when we know for sure the layer
is already supposed to be composited.
Also, added a bounding box of the overlap map, so that it can catch cases when the new layer is not overlapping
any of the previous layers. This is pretty common when having composited layers laid out in a vertical/horizontal list.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Simon Fraser (smfr)
> added a bounding box of the overlap map
Pretty sure I did this already.
Ahmad Saleem
I think - https://github.com/WebKit/WebKit/blob/a6f01813f5c40a8f103e0219354defaa1adae860/Source/WebCore/rendering/LayerOverlapMap.cpp
cover these bits? Is something more required? Thanks!