Bug 115146

Summary: cloneChildNodes looks for deleteButtonController in each level of recursion
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eflews.bot, esprehn+autocc, ggaren, gyuyoung.kim, kling, koivisto, webkit-bug-importer, webkit-ews
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Cleanup
none
Fixed builds
none
Fixed spelling none

Ryosuke Niwa
Reported 2013-04-24 20:27:09 PDT
cloneChildNodes looks for deleteButtonController in each level of recursion
Attachments
Cleanup (3.22 KB, patch)
2013-04-24 20:29 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Fixed builds (3.27 KB, patch)
2013-04-24 20:40 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Fixed spelling (3.28 KB, patch)
2013-04-24 20:45 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2013-04-24 20:29:59 PDT
Created attachment 199611 [details] Cleanup
Radar WebKit Bug Importer
Comment 2 2013-04-24 20:33:20 PDT
<rdar://problem/13734528>
Early Warning System Bot
Comment 3 2013-04-24 20:37:58 PDT
Comment on attachment 199611 [details] Cleanup Attachment 199611 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/157950
EFL EWS Bot
Comment 4 2013-04-24 20:39:02 PDT
Comment on attachment 199611 [details] Cleanup Attachment 199611 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/207067
Early Warning System Bot
Comment 5 2013-04-24 20:39:16 PDT
Comment on attachment 199611 [details] Cleanup Attachment 199611 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/38505
EFL EWS Bot
Comment 6 2013-04-24 20:39:50 PDT
Comment on attachment 199611 [details] Cleanup Attachment 199611 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/220086
Ryosuke Niwa
Comment 7 2013-04-24 20:40:31 PDT
Created attachment 199612 [details] Fixed builds
Geoffrey Garen
Comment 8 2013-04-24 20:42:26 PDT
> Source/WebCore/dom/ContainerNode.cpp:861 > + cloneChildNodesAvoidingDeleteButon(this, clone, deleteButtonContainerElement); Spelling: Should be "cloneChildNodesAvoidingDeleteButton".
Ryosuke Niwa
Comment 9 2013-04-24 20:45:17 PDT
Created attachment 199613 [details] Fixed spelling
Andreas Kling
Comment 10 2013-04-25 05:44:09 PDT
Comment on attachment 199613 [details] Fixed spelling r=me
WebKit Commit Bot
Comment 11 2013-04-25 11:32:19 PDT
Comment on attachment 199613 [details] Fixed spelling Clearing flags on attachment: 199613 Committed r149127: <http://trac.webkit.org/changeset/149127>
WebKit Commit Bot
Comment 12 2013-04-25 11:32:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.