Bug 115111

Summary: [GTK] Update build dependencies
Product: WebKit Reporter: Simon Pena <spenap>
Component: WebKitGTKAssignee: Simon Pena <spenap>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Simon Pena 2013-04-24 09:04:56 PDT 
Tools/gtk/install-dependencies is missing the EGL dependency.
Comment 1 Simon Pena 2013-04-24 09:09:46 PDT 
Created attachment 199492 [details]
Patch
Comment 2 Martin Robinson 2013-04-24 09:21:09 PDT 
Comment on attachment 199492 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=199492&action=review

> Tools/gtk/install-dependencies:58
> +        libegl1-mesa-dev \

These should really be in the second section: "These are dependencies necessary for running tests." since they are really just dependencies necessary for the jhbuild.
Comment 3 Martin Robinson 2013-04-24 09:21:52 PDT 
Comment on attachment 199492 [details]
Patch

Looks good, but perhaps put them in the second list when landing.
Comment 4 Simon Pena 2013-04-24 10:21:06 PDT 
Created attachment 199497 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2013-04-24 10:49:24 PDT 
Comment on attachment 199497 [details]
Patch for landing

Clearing flags on attachment: 199497

Committed r149048: <http://trac.webkit.org/changeset/149048>
Comment 6 WebKit Commit Bot 2013-04-24 10:49:26 PDT 
All reviewed patches have been landed.  Closing bug.