Bug 115066

Summary:

[EFL][WK2] Build break after r149004

Product:

WebKit

Reporter:

Ryuan Choi <ryuan.choi>

Component:

WebKit EFL

Assignee:

Ryuan Choi <ryuan.choi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarcelo, commit-queue, lucas.de.marchi, luiz, noam, simon.fraser, thorton, zeno

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Ryuan Choi

Reported 2013-04-23 17:04:51 PDT

Below errors occured. [ 83%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/__/__/DerivedSources/WebKit2/CoordinatedLayerTreeHostMessageReceiver.cpp.o /home/ryuan/workspace/project/webkit/efl-webkit/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp: In static member function ‘static WTF::PassRefPtr<WebKit::CoordinatedLayerTreeHost> WebKit::CoordinatedLayerTreeHost::create(WebKit::WebPage*)’: /home/ryuan/workspace/project/webkit/efl-webkit/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:66:57: error: cannot allocate an object of abstract type ‘WebKit::CoordinatedLayerTreeHost’ In file included from /home/ryuan/workspace/project/webkit/efl-webkit/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:31:0: /home/ryuan/workspace/project/webkit/efl-webkit/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:48:7: note: because the following virtual functions are pure within ‘WebKit::CoordinatedLayerTreeHost’: In file included from /home/ryuan/workspace/project/webkit/efl-webkit/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:26:0, from /home/ryuan/workspace/project/webkit/efl-webkit/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:31: /home/ryuan/workspace/project/webkit/efl-webkit/Source/WebKit2/WebProcess/WebPage/LayerTreeHost.h:75:18: note: virtual void WebKit::LayerTreeHost::pageBackgroundTransparencyChanged() /home/ryuan/workspace/project/webkit/efl-webkit/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:67:1: error: control reaches end of non-void function [-Werror=return-type] cc1plus: all warnings being treated as errors make[2]: *** [Source/WebKit2/CMakeFiles/ewebkit2.dir/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp.o] Error 1

Attachments
Patch (2.48 KB, patch) 2013-04-23 17:13 PDT, Ryuan Choi	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Ryuan Choi

Comment 1 2013-04-23 17:13:10 PDT

Created attachment 199339 [details] Patch

Ryuan Choi

Comment 2 2013-04-23 17:19:31 PDT

Committed r149008: <http://trac.webkit.org/changeset/149008>

Ryuan Choi

Comment 3 2013-04-23 17:21:44 PDT

Comment on attachment 199339 [details] Patch clear the flag. thank you.

Note You need to log in before you can comment on or make changes to this bug.