Bug 115055

Summary: [BlackBerry] Do not clear focus on a node when tapping on form controls
Product: WebKit Reporter: Nima Ghanavatian <nghanavatian>
Component: WebKit BlackBerryAssignee: Nima Ghanavatian <nghanavatian>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Nima Ghanavatian
Reported 2013-04-23 13:53:08 PDT
For rich text editors to work correctly, we must maintain focus on an input field and allow for mouse presses to trigger on buttons/form controls. This allows us to pass styles down to the text in the field, whether it is highlighted or will be entered after.
Attachments
Patch (6.70 KB, patch)
2013-04-23 13:58 PDT, Nima Ghanavatian 		no flags
DetailsFormatted DiffDiff
Patch (6.70 KB, patch)
2013-04-24 08:46 PDT, Nima Ghanavatian 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nima Ghanavatian
Comment 1 2013-04-23 13:58:08 PDT
Created attachment 199323 [details] Patch
Rob Buis
Comment 2 2013-04-24 08:33:03 PDT
Comment on attachment 199323 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=199323&action=review Looks good, but please fix the ChangeLog before landing. > Source/WebKit/blackberry/ChangeLog:12 > + or highlighted text, we must maintain focus the current focus I don't get the "focus the current focus" part. > Source/WebKit/blackberry/ChangeLog:14 > + context to trigger off of TouchHold instead of TouchPress. I think you do not want the first 'of' there.
Nima Ghanavatian
Comment 3 2013-04-24 08:46:58 PDT
Created attachment 199489 [details] Patch
Rob Buis
Comment 4 2013-04-24 08:48:45 PDT
Comment on attachment 199489 [details] Patch LGTM.
WebKit Commit Bot
Comment 5 2013-04-24 08:58:46 PDT
Comment on attachment 199489 [details] Patch Clearing flags on attachment: 199489 Committed r149043: <http://trac.webkit.org/changeset/149043>
WebKit Commit Bot
Comment 6 2013-04-24 08:58:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.