Bug 115041

Summary: [BlackBerry] Do not access BackForwardListImpl from DRT
Product: WebKit Reporter: Xan Lopez <xan.lopez>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, rwlbuis, staikos, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
bflist.diff none

Xan Lopez
Reported 2013-04-23 08:12:28 PDT
Our DRT implementation casts the BF list client class (BackForwardListBlackBerry) to BackForwardListImpl through a static_cast. This is wrong because the impl is a private member of BackForwardListBlackBerry, *not* its parent class. Most fast/history tests are failing via memory corruption because of this.
Attachments
bflist.diff (5.68 KB, patch)
2013-04-23 08:28 PDT, Xan Lopez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Xan Lopez
Comment 1 2013-04-23 08:28:12 PDT
Created attachment 199242 [details] bflist.diff This fixes every single crash in fast/history.
Carlos Garcia Campos
Comment 2 2013-04-23 08:33:36 PDT
Comment on attachment 199242 [details] bflist.diff Good catch, this is indeed my fault, I missed this one when added BackForwardListBlackBerry. Thanks!
WebKit Commit Bot
Comment 3 2013-04-23 09:02:37 PDT
Comment on attachment 199242 [details] bflist.diff Clearing flags on attachment: 199242 Committed r148969: <http://trac.webkit.org/changeset/148969>
WebKit Commit Bot
Comment 4 2013-04-23 09:02:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.