Bug 11504

Summary: Fix warnings on non 32 bit platforms
Product: WebKit Reporter: Zack Rusin <zack>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: ap
Priority: P2    
Version: 420+   
Hardware: PC   
OS: Linux   
Bug Depends on: 11508    
Bug Blocks:    
Description Flags
fix warning by explicitly casting
timothy: review+
alternative fix darin: review+

Description Zack Rusin 2006-11-03 05:25:52 PST
On platforms with 32bit userspace, uintptr_t is 32bits so compiler complains about truncating a 64bit type to 32bits. This is basically the same casts we added in kdelibs to kjs.
Comment 1 Zack Rusin 2006-11-03 05:26:30 PST
Created attachment 11363 [details]
fix warning by explicitly casting
Comment 2 Timothy Hatcher 2006-11-03 09:20:24 PST
Comment on attachment 11363 [details]
fix warning by explicitly casting

Looks fine. static_cast would be safer.
Comment 3 Alexey Proskuryakov 2006-11-03 09:52:10 PST
Created attachment 11364 [details]
alternative fix

This should fix the issue by eliminating runtime checks.
Comment 4 Darin Adler 2006-11-03 12:27:26 PST
Comment on attachment 11364 [details]
alternative fix

I think Alexey's fix is better.

Comment 5 Alexey Proskuryakov 2006-11-03 14:21:18 PST
Committed revision 17580. Here's hope that my fix actually helps :-)