Summary: | Plugin Snapshotting: Don't consume insane amounts of time detecting the primary plugin | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
Component: | Plug-ins | Assignee: | Tim Horton <thorton> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | dino, sam, simon.fraser | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Tim Horton
2013-04-22 15:13:28 PDT
Created attachment 199117 [details]
patch
Going to test more before landing. Comment on attachment 199117 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=199117&action=review > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:3949 > +void WebPage::determinePrimarySnapshottedPlugInTimerFired() > +{ > +#if ENABLE(PRIMARY_SNAPSHOTTED_PLUGIN_HEURISTIC) > + if (!m_page->settings()->snapshotAllPlugIns() && m_page->settings()->primaryPlugInSnapshotDetectionEnabled()) > + determinePrimarySnapshottedPlugIn(); > +#endif > +} You probably want to put the entire function body inside the #if. |