Bug 114983

Summary: [GTK] Enable introspection always for developer builds
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, dbates, gustavo, pnormand, zan
Priority: P2    
Version: 523.x (Safari 3)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch gustavo: review+

Description Martin Robinson 2013-04-22 12:30:03 PDT
If we enable introspection always we can sniff out issues sooner and turn the EWS bubble red when API is introduced without proper annotations.
Comment 1 Martin Robinson 2013-04-22 14:01:39 PDT
Created attachment 199107 [details]
Patch
Comment 2 Gustavo Noronha (kov) 2013-04-22 14:51:09 PDT
Comment on attachment 199107 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=199107&action=review

> Source/WebKit2/ChangeLog:8
> +        * GNUmakefile.am: Make warnings cause the build to fail. Eliminate

Be good to make it obvious you're talking about the scanner build here.

> Source/WebKit/gtk/GNUmakefile.am:300
> -	$(AM_V_GEN)$(G_IR_SCANNER) -v --warn-all \
> +	$(AM_V_GEN) \
> +	     CFLAGS="$(CFLAGS) -Wno-deprecated-declarations" \
> +	     $(G_IR_SCANNER) \
> +	     --quiet \

Is girscanner still verbose enough to help debug issues shown by the EWS after replacing -v with --quiet here? Other than that it's a great idea, and the patch looks OK to me.
Comment 3 Martin Robinson 2013-04-22 15:14:31 PDT
Committed r148916: <http://trac.webkit.org/changeset/148916>
Comment 4 Martin Robinson 2013-04-22 15:15:40 PDT
(In reply to comment #2)
> (From update of attachment 199107 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=199107&action=review
> 
> > Source/WebKit2/ChangeLog:8
> > +        * GNUmakefile.am: Make warnings cause the build to fail. Eliminate
> 
> Be good to make it obvious you're talking about the scanner build here.

Sound good.

> > Source/WebKit/gtk/GNUmakefile.am:300
> > -	$(AM_V_GEN)$(G_IR_SCANNER) -v --warn-all \
> > +	$(AM_V_GEN) \
> > +	     CFLAGS="$(CFLAGS) -Wno-deprecated-declarations" \
> > +	     $(G_IR_SCANNER) \
> > +	     --quiet \
> 
> Is girscanner still verbose enough to help debug issues shown by the EWS after replacing -v with --quiet here? Other than that it's a great idea, and the patch looks OK to me.

When not in quiet mode, g-ir-scanner prints the command-line it uses to compile the scanning program, which, for us, is many lines long. On the other hand it does print out the details of any problems it finds when --quiet is active.