Summary: | [32-bit] JavaScriptCore JIT build is broken for 32-bit arch since r148893 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Julien Brianceau <jbriance> | ||||
Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ggaren, mark.lam, oliver | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Julien Brianceau
2013-04-22 10:48:57 PDT
The JIT::emit_op_loop_hint and JIT::emitSlow_op_loop_hint are implemented inside #if USE(JSVALUE64). Is this really needed ? Can I move them outside ? Once moved out, there is also one missing implementation in MacroAssemblerSH4.h of branchAdd32: Jump branchAdd32(ResultCondition cond, TrustedImm32 imm, AbsoluteAddress dest) I'll submit a patch soon, From what I can tell, apart from the 32-bit build issue, the SH4 branchAdd32 is not missing an implementation. However, their asserts for acceptable ResultConditions need to be updated, which I will do with this patch as well. Created attachment 199054 [details]
the fix
Fix landed in r148899: <http://trac.webkit.org/changeset/148899>. |