Bug 114964 – AX: some images having no label but having other global attributes (like aria-describedby) are treated as presentational

• Component: Accessibility
• Status: RESOLVED WORKSFORME

[James Craig]

AX: some images having no label but having other global attributes (like aria-describedby) are treated as presentational.

https://dvcs.w3.org/hg/pfwg/raw-file/default/ARIA/1.0/tests/test-files/aria-describedby/774.html

[Radar WebKit Bug Importer]

<rdar://problem/13706175>

[James Craig]

Created attachment 199040 [details]
test case demonstrating bug

Uploading test case b/c I'm about to "fix" the original to only test what it's supposed to be testing.

[chris fleizach]

Created attachment 220889 [details]
patch

[Mario Sanchez Prada]

Comment on attachment 220889 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=220889&action=review

> Source/WebCore/accessibility/AccessibilityObject.cpp:1664
>          || hasAttribute(aria_invalidAttr)
>          || hasAttribute(aria_labelAttr)
>          || hasAttribute(aria_labelledbyAttr)
> +        || hasAttribute(aria_describedbyAttr)

I don't really understand how this change fixes the problem, since that check is already present a few lines above in this return statement.

Current version in my local copy:

bool AccessibilityObject::supportsARIAAttributes() const
{
    // This returns whether the element supports any global ARIA attributes.
    return supportsARIALiveRegion()
        || supportsARIADragging()
        || supportsARIADropping()
        || supportsARIAFlowTo()
        || supportsARIAOwns()
        || hasAttribute(aria_atomicAttr)
        || hasAttribute(aria_busyAttr)
        || hasAttribute(aria_controlsAttr)
        || hasAttribute(aria_describedbyAttr)
        || hasAttribute(aria_disabledAttr)
        || hasAttribute(aria_haspopupAttr)
        || hasAttribute(aria_invalidAttr)
        || hasAttribute(aria_labelAttr)
        || hasAttribute(aria_labelledbyAttr)
        || hasAttribute(aria_relevantAttr);
}

Looking at this and seeing that the test case you added is basically the one mentioned by James in comment #2, it looks to me like the bug is not present there anymore. Maybe he's using an old version of WebKit?

From what I can see, most of the conditions in that return statement were added in September, as part of the fix for bug 120373 ("AX: aria-relevant does not expose AXARIARelevant").

> LayoutTests/accessibility/aria-describedby-ensures-visibility.html:23
> +

Extra blank line

[chris fleizach]

(In reply to comment #4)
> (From update of attachment 220889 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=220889&action=review
> 
> > Source/WebCore/accessibility/AccessibilityObject.cpp:1664
> >          || hasAttribute(aria_invalidAttr)
> >          || hasAttribute(aria_labelAttr)
> >          || hasAttribute(aria_labelledbyAttr)
> > +        || hasAttribute(aria_describedbyAttr)
> 
> I don't really understand how this change fixes the problem, since that check is already present a few lines above in this return statement.
> 
> Current version in my local copy:
> 
> bool AccessibilityObject::supportsARIAAttributes() const
> {
>     // This returns whether the element supports any global ARIA attributes.
>     return supportsARIALiveRegion()
>         || supportsARIADragging()
>         || supportsARIADropping()
>         || supportsARIAFlowTo()
>         || supportsARIAOwns()
>         || hasAttribute(aria_atomicAttr)
>         || hasAttribute(aria_busyAttr)
>         || hasAttribute(aria_controlsAttr)
>         || hasAttribute(aria_describedbyAttr)
>         || hasAttribute(aria_disabledAttr)
>         || hasAttribute(aria_haspopupAttr)
>         || hasAttribute(aria_invalidAttr)
>         || hasAttribute(aria_labelAttr)
>         || hasAttribute(aria_labelledbyAttr)
>         || hasAttribute(aria_relevantAttr);
> }
> 
> Looking at this and seeing that the test case you added is basically the one mentioned by James in comment #2, it looks to me like the bug is not present there anymore. Maybe he's using an old version of WebKit?
> 
> From what I can see, most of the conditions in that return statement were added in September, as part of the fix for bug 120373 ("AX: aria-relevant does not expose AXARIARelevant").
> 
> > LayoutTests/accessibility/aria-describedby-ensures-visibility.html:23
> > +
> 
> Extra blank line

weird. i swear when I tested the sample test case it failed before my fix. maybe my source was way out date