| Summary: | WTF::AtomicString::find() should take unsigned 'start' argument | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
| Component: | Web Template Framework | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | barraclough, benjamin, cmarcelo, commit-queue | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 107093 | ||||||
| Attachments: |
|
||||||
Created attachment 199027 [details]
Patch v1
> WTF::AtomicString::find() should take unsigned 'start' argument
Because WTF::String::find() takes an unsigned 'start' argument.
Comment on attachment 199027 [details] Patch v1 Clearing flags on attachment: 199027 Committed r148884: <http://trac.webkit.org/changeset/148884> All reviewed patches have been landed. Closing bug. |
Fixes the following warnings with -Wshorten-64-to-32: AtomicString.h:113:76: error: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'unsigned int' [-Werror,-Wshorten-64-to-32] size_t find(UChar c, size_t start = 0) const { return m_string.find(c, start); } ~~~~~~~~ ^~~~~ AtomicString.h:115:35: error: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'unsigned int' [-Werror,-Wshorten-64-to-32] { return m_string.find(s, start, caseSentitive); } ~~~~~~~~ ^~~~~ AtomicString.h:117:35: error: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'unsigned int' [-Werror,-Wshorten-64-to-32] { return m_string.find(s, start, caseSentitive); } ~~~~~~~~ ^~~~~