| Summary: | [BlackBerry] Crash due to an assert running test editing/execCommand/indent-paragraphs.html | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||||
| Component: | WebKit BlackBerry | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, rwlbuis | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 116101 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
Created attachment 199009 [details]
Patch
Comment on attachment 199009 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=199009&action=review Looks great, but the new early exit needs to be verified and at least an error/log has to be there. > Source/WebCore/platform/network/blackberry/ResourceHandleBlackBerry.cpp:160 > + if (!NetworkManager::instance()->startJob(playerId, handle, frame, defersLoading)) It would be nice to set the error param here. Created attachment 201706 [details] Updated patch Updated to return a StatusErrorInvalidUrl error. It depends on bug #116101. Comment on attachment 201706 [details]
Updated patch
Looks good.
Comment on attachment 201706 [details] Updated patch Clearing flags on attachment: 201706 Committed r150224: <http://trac.webkit.org/changeset/150224> All reviewed patches have been landed. Closing bug. |
It crashes in network platform code when trying to save an invalid URL in the disk cache. The test contains the following HTML code: <div id="test"> <div><span class="Apple-style-span" style="background-color: rgb(255, 0, 0);">Hello <img src="http://"> world</span></div> <div>Hello <img src="http://"> world</span></div> Hello <img src="http://"> world </div> Those empty URLs, are parsed as http:/ by KURL and considered valid. BlockBerry network platform uses GURL which considers those URLs invalid. We needed to check that the URLs are valid for our platform before starting the network operation.