Bug 114937

Summary: Avoid walking up the tree in RenderBoxModelObject::setSelectionState
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Normal CC: enrica, hyatt, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 113478    
Attachments:
Description Flags
Work in progress none

Ryosuke Niwa
Reported 2013-04-22 00:09:34 PDT
Right now, RenderBoxModelObject::setSelectionState walks up the tree in order to set the selection states on its ancestors. However, this is a very redundant operation since many render objects upon which setSelectionState is called share the same containing blocks. Furthermore, there is no need to walk through the tree to look for newly selected objects the second time after updating selection states.
Attachments
Work in progress (13.31 KB, patch)
2013-04-22 02:14 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2013-04-22 02:14:42 PDT
Created attachment 199007 [details] Work in progress
Ryosuke Niwa
Comment 2 2013-04-22 02:15:06 PDT
This turned out to be a bad change. It causes a performance regression instead of progression :(
Note You need to log in before you can comment on or make changes to this bug.