Bug 114912

Summary:

Regression(r148672): fast/events/touch/frame-hover-update.html fails

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Tools / Tests

Assignee:

Allan Sandfeld Jensen <allan.jensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

allan.jensen, commit-queue, tonikitoo

Priority:

Keywords:

EasyFix

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

114446, 114917

Attachments:

Description	Flags
Patch	none
Patch	none

Description Chris Dumez 2013-04-21 04:11:29 PDT

fast/events/touch/frame-hover-update.html fails after being introduced in <http://trac.webkit.org/changeset/148672> with the following error message:
CONSOLE MESSAGE: line 43: ReferenceError: Can't find variable: shouldBeNonNull

Looks like the js-test-pre.js script is incorrectly included.

Comment 1 Chris Dumez 2013-04-21 06:40:01 PDT

Created attachment 198963 [details]
Patch

Comment 2 Allan Sandfeld Jensen 2013-04-21 06:53:15 PDT

Comment on attachment 198963 [details]
Patch

LGTM

Comment 3 WebKit Commit Bot 2013-04-21 07:20:55 PDT

Comment on attachment 198963 [details]
Patch

Clearing flags on attachment: 198963

Committed r148831: <http://trac.webkit.org/changeset/148831>

Comment 4 WebKit Commit Bot 2013-04-21 07:20:57 PDT

All reviewed patches have been landed.  Closing bug.

Comment 5 Antonio Gomes 2013-04-21 08:46:35 PDT

Thanks Chris.

Comment 6 Allan Sandfeld Jensen 2013-04-21 10:36:49 PDT

The same fix is needed for the link to js-test-post.js

Comment 7 Chris Dumez 2013-04-21 13:04:04 PDT

Created attachment 198971 [details]
Patch

Comment 8 Chris Dumez 2013-04-21 13:04:45 PDT

(In reply to comment #6)
> The same fix is needed for the link to js-test-post.js

Right. Sorry about that. I uploaded a follow-up patch for this.

Comment 9 WebKit Commit Bot 2013-04-21 13:51:24 PDT

Comment on attachment 198971 [details]
Patch

Clearing flags on attachment: 198971

Committed r148847: <http://trac.webkit.org/changeset/148847>

Comment 10 WebKit Commit Bot 2013-04-21 13:51:26 PDT

All reviewed patches have been landed.  Closing bug.