Bug 114912

Summary: Regression(r148672): fast/events/touch/frame-hover-update.html fails
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Tools / TestsAssignee: Allan Sandfeld Jensen <allan.jensen>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, commit-queue, tonikitoo
Priority: P2 Keywords: EasyFix
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 114446, 114917    
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2013-04-21 04:11:29 PDT
fast/events/touch/frame-hover-update.html fails after being introduced in <http://trac.webkit.org/changeset/148672> with the following error message: CONSOLE MESSAGE: line 43: ReferenceError: Can't find variable: shouldBeNonNull Looks like the js-test-pre.js script is incorrectly included.
Attachments
Patch (1.17 KB, patch)
2013-04-21 06:40 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (1.15 KB, patch)
2013-04-21 13:04 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2013-04-21 06:40:01 PDT
Created attachment 198963 [details] Patch
Allan Sandfeld Jensen
Comment 2 2013-04-21 06:53:15 PDT
Comment on attachment 198963 [details] Patch LGTM
WebKit Commit Bot
Comment 3 2013-04-21 07:20:55 PDT
Comment on attachment 198963 [details] Patch Clearing flags on attachment: 198963 Committed r148831: <http://trac.webkit.org/changeset/148831>
WebKit Commit Bot
Comment 4 2013-04-21 07:20:57 PDT
All reviewed patches have been landed. Closing bug.
Antonio Gomes
Comment 5 2013-04-21 08:46:35 PDT
Thanks Chris.
Allan Sandfeld Jensen
Comment 6 2013-04-21 10:36:49 PDT
The same fix is needed for the link to js-test-post.js
Chris Dumez
Comment 7 2013-04-21 13:04:04 PDT
Created attachment 198971 [details] Patch
Chris Dumez
Comment 8 2013-04-21 13:04:45 PDT
(In reply to comment #6) > The same fix is needed for the link to js-test-post.js Right. Sorry about that. I uploaded a follow-up patch for this.
WebKit Commit Bot
Comment 9 2013-04-21 13:51:24 PDT
Comment on attachment 198971 [details] Patch Clearing flags on attachment: 198971 Committed r148847: <http://trac.webkit.org/changeset/148847>
WebKit Commit Bot
Comment 10 2013-04-21 13:51:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.