| Summary: | Fix some minor bad use of strings in WebCore | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||
| Component: | New Bugs | Assignee: | Benjamin Poulain <benjamin> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | ||||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Benjamin Poulain
2013-04-20 19:13:49 PDT
Created attachment 198950 [details]
Patch
Comment on attachment 198950 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=198950&action=review > Source/WebCore/ChangeLog:9 > + (WebCore::Editor::selectedText): This was implictely getting the emptyString(). Typo or spelling error: should be "implicitly". But also, I don’t understand what you mean. Do you mean that 0 was turning into the null string? > But also, I don’t understand what you mean. Do you mean that 0 was turning into the null string?
This
replace(0, "")
Would turn into this (there is no replace for char*):
replace((UChar)0, String(""))
And the constructor of String return the empty string if the length is 0 :(
Committed r148854: <http://trac.webkit.org/changeset/148854> |