Bug 114902

Summary: [Part 5] Parse color value for custom() function parameters
Product: WebKit Reporter: Dirk Schulze <krit>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, commit-queue, dino, esprehn+autocc, kling, macpherson, menard, syoichi
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 71395, 113695    
Attachments:
Description Flags
Patch.
dino: review+
Patch for landing. none

Description Dirk Schulze 2013-04-20 08:03:52 PDT
Parse color value for custom() function parameters.
Comment 1 Dirk Schulze 2013-04-20 08:26:31 PDT
Created attachment 198943 [details]
Patch.
Comment 2 WebKit Commit Bot 2013-04-20 08:28:19 PDT
Attachment 198943 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/css3/filters/custom-with-at-rule-syntax/parsing-custom-function-invalid-expected.txt', u'LayoutTests/css3/filters/custom-with-at-rule-syntax/parsing-custom-function-valid-expected.txt', u'LayoutTests/css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-invalid-expected.txt', u'LayoutTests/css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-valid-expected.txt', u'LayoutTests/css3/filters/custom-with-at-rule-syntax/script-tests/parsing-custom-function-invalid.js', u'LayoutTests/css3/filters/custom-with-at-rule-syntax/script-tests/parsing-custom-function-valid.js', u'LayoutTests/css3/filters/custom-with-at-rule-syntax/script-tests/parsing-parameters-property-invalid.js', u'LayoutTests/css3/filters/custom-with-at-rule-syntax/script-tests/parsing-parameters-property-valid.js', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/css/CSSComputedStyleDeclaration.cpp', u'Source/WebCore/css/CSSParser.cpp', u'Source/WebCore/css/StyleResolver.cpp', u'Source/WebCore/css/StyleResolver.h', u'Source/WebCore/platform/graphics/filters/CustomFilterColorParameter.h', u'Source/WebCore/platform/graphics/filters/CustomFilterParameter.h', u'Source/WebCore/platform/graphics/filters/CustomFilterRenderer.cpp']" exit_code: 1
Source/WebCore/platform/graphics/filters/CustomFilterParameter.h:47:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Source/WebCore/platform/graphics/filters/CustomFilterColorParameter.h:34:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dirk Schulze 2013-04-20 08:41:33 PDT
I can fix the ordering issue before landing. I would rather not change the capitalization on the enum values with this patch.
Comment 4 Dean Jackson 2013-04-20 14:01:42 PDT
Comment on attachment 198943 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=198943&action=review

> Source/WebCore/ChangeLog:10
> +        add the color values to the sahder program.

Typo: shader
Comment 5 Dirk Schulze 2013-04-20 19:48:44 PDT
Created attachment 198952 [details]
Patch for landing.
Comment 6 WebKit Commit Bot 2013-04-20 20:31:19 PDT
Comment on attachment 198952 [details]
Patch for landing.

Clearing flags on attachment: 198952

Committed r148802: <http://trac.webkit.org/changeset/148802>
Comment 7 WebKit Commit Bot 2013-04-20 20:31:22 PDT
All reviewed patches have been landed.  Closing bug.