Bug 114891 – Battery API won't return updated battery status until client calls didChangeBatteryStatus

• Component: WebKit API
• Status: RESOLVED FIXED

The battery status object in BatteryManager won't get updated until the client calls didChangeBatteryStatus in the controller. If we have a web page that only calls webkitBattery.charge() and there's no update from the client between the creation of addListener(BatteryManager) and the next didChangeBatteryStatus, the BatteryManager will always return the default value because m_batteryStatus is always null.

We need to update the manager when we attach it to the controller, and update all existing managers when the controller receives it's first battery status object.

Created attachment 198918 [details]
Patch

Hi Kihong, would you be free to take a look at the small fix I made to the battery module?

[Kihong Kwon]

I couldn't see any problem with this and IMO, this is good point. :)
But, as you may know, updateBatteryStatus is only for chromium.
Therefore if you don't have a plan to use it, this patch is meaningless.

[Rob Buis]

Comment on attachment 198918 [details]
Patch

LGTM.

thanks for your help Kihong!

[WebKit Commit Bot]

Comment on attachment 198918 [details]
Patch

Clearing flags on attachment: 198918

Committed r149063: <http://trac.webkit.org/changeset/149063>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.