| Summary: | Fixing rendering of line edits on Qt platform | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zack Rusin <zack> | ||||||||
| Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | ||||||||||
| Priority: | P2 | ||||||||||
| Version: | 420+ | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Linux | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Zack Rusin
2006-11-01 07:14:57 PST
Created attachment 11326 [details]
Use Qt style to render line edits
Comment on attachment 11326 [details]
Use Qt style to render line edits
Thanks for the patch!
The code changes in this patch look fine.
However, I do not think the commented code would be the right approach to handling a style that leaves less room for contents. Instead, the RenderTheme should adjust the border and padding when adjusting the style in such cases. Also we usually put "FIXME:" as a prefix for things like this that need to be looked at, not "###". r- to give you a chance to update the comment but I'll happily r+ once that is done (or if you decide to leave it as-is -- not such a big deal). Either way, just reflag it when ready.
Created attachment 11344 [details]
updated patch
Comment on attachment 11344 [details]
updated patch
Cool, you actually implemented the padding stuff. However, style changes should be done in RenderThemeQt::adjustTextFieldStyle, not paintTextField, to match how the other themes do things.
Landed. Oops, wrong bug. Created attachment 11362 [details]
updated to skip padding adjustments for now
Comment on attachment 11362 [details]
updated to skip padding adjustments for now
r=me
|