Bug 11484

Summary: Fixing rendering of line edits on Qt platform
Product: WebKit Reporter: Zack Rusin <zack>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Use Qt style to render line edits
mjs: review-
updated patch
none
updated to skip padding adjustments for now mjs: review+

Zack Rusin
Reported 2006-11-01 07:14:57 PST
Line edits were rendered using drawRect, which looks worse than a horse after a western movie. The attached patch fixes it.
Attachments
Use Qt style to render line edits (2.02 KB, patch)
2006-11-01 07:15 PST, Zack Rusin 		mjs: review-
DetailsFormatted DiffDiff
updated patch (2.71 KB, patch)
2006-11-02 07:10 PST, Zack Rusin 		no flags
DetailsFormatted DiffDiff
updated to skip padding adjustments for now (1.71 KB, patch)
2006-11-03 05:00 PST, Zack Rusin 		mjs: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Zack Rusin
Comment 1 2006-11-01 07:15:29 PST
Created attachment 11326 [details] Use Qt style to render line edits
Maciej Stachowiak
Comment 2 2006-11-01 15:23:46 PST
Comment on attachment 11326 [details] Use Qt style to render line edits Thanks for the patch! The code changes in this patch look fine. However, I do not think the commented code would be the right approach to handling a style that leaves less room for contents. Instead, the RenderTheme should adjust the border and padding when adjusting the style in such cases. Also we usually put "FIXME:" as a prefix for things like this that need to be looked at, not "###". r- to give you a chance to update the comment but I'll happily r+ once that is done (or if you decide to leave it as-is -- not such a big deal). Either way, just reflag it when ready.
Zack Rusin
Comment 3 2006-11-02 07:10:24 PST
Created attachment 11344 [details] updated patch
Maciej Stachowiak
Comment 4 2006-11-02 15:06:50 PST
Comment on attachment 11344 [details] updated patch Cool, you actually implemented the padding stuff. However, style changes should be done in RenderThemeQt::adjustTextFieldStyle, not paintTextField, to match how the other themes do things.
Maciej Stachowiak
Comment 5 2006-11-03 01:41:27 PST
Landed.
Maciej Stachowiak
Comment 6 2006-11-03 01:41:51 PST
Oops, wrong bug.
Zack Rusin
Comment 7 2006-11-03 05:00:44 PST
Created attachment 11362 [details] updated to skip padding adjustments for now
Maciej Stachowiak
Comment 8 2006-11-03 14:36:15 PST
Comment on attachment 11362 [details] updated to skip padding adjustments for now r=me
Mark Rowe (bdash)
Comment 9 2006-11-03 21:18:47 PST
Landed in r17588. Thanks Zack.
Note You need to log in before you can comment on or make changes to this bug.