Summary: | REGRESSION(r148639): Interpreter entry points should throw the TerminatedExecutionException from the caller frame | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jessie Berlin <jberlin> | ||||||||||
Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | buildbot, dfarler, ggaren, oliver, rniwa, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Jessie Berlin
2013-04-18 08:44:12 PDT
Created attachment 198756 [details]
the fix 2.
This fixes the assertion failure crash. I’m still seeing some "FAIL: Timed out waiting for notifyDone to be called” that seems to be failing consistently in fast/workers/dedicated-worker-lifecycle.html and causing stderr output in:
fast/workers/worker-document-leak.html
fast/workers/worker-lifecycle.html
fast/workers/worker-close-more.html
That is a separate issue which I’ll investigate in a separate bug.
Created attachment 198765 [details]
new fix: Oliver convinced me to throw from the caller frame instead
Created attachment 198768 [details]
patch 3: svn up'ed
Comment on attachment 198768 [details] patch 3: svn up'ed Attachment 198768 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/158041 New failing tests: fast/repaint/japanese-rl-selection-repaint-in-regions.html Created attachment 198775 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.2
Comment on attachment 198768 [details]
patch 3: svn up'ed
nice!
(In reply to comment #6) > Created an attachment (id=198775) [details] > Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 > > The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. > Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.2 This is totally unrelated. Will ignore. Thanks for the review. Landed in r148709: <http://trac.webkit.org/changeset/148709>. |